From: Lukasz Majewski <lukma@denx.de>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org, Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t
Date: Sun, 24 Mar 2019 23:17:19 +0100 [thread overview]
Message-ID: <20190324231655.2ee728f1@jawa> (raw)
In-Reply-To: <20190323223407.2f6d47e8@jawa>
[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]
Hi Paul,
> Hi Paul,
>
> > On 3/20/19 12:03 AM, Lukasz Majewski wrote:
> > > Do you plan to prepare (and send to mailing list) the next version
> > > of this patch (including the above fix)?
> >
> > Sure, attached.
> >
> > > In the time/mktime.c there is:
> > > weak_alias (mktime, timelocal), which makes the timelocal calls
> > > aliases to mktime for time_t 32 and 64 bit (for Y2038 the proper
> > > __REDIRECT will be added).
> > > Sorry, I'm a bit lost here. How will that __REDIRECT work,
> > > exactly? Should it be part of this patch, or part of a later
> > > patch? The __REDIRECT would be a part of the latter patch - the
> > > one which adds Y2038 support for 32 bit SoCs.
> > >
> > > It would simply redirect calls to mktime/timegm to internal
> > > __mktime64()/__timegm64().
> > >
> > OK, in that case, it can redirect timelocal calls to __mktime64, and
> > there is no need for a __timelocal64.
> >
>
> Thanks for the updated patch. I don't know why I've just received your
> e-mail (but it is from Friday).
>
> Today (Sat, around 12:00 CET), I've spent some time on testing your
> previous work and write some comments/fixes in the other mail.
>
> The code can be found in:
> https://github.com/lmajewski/y2038_glibc/commits/mktime_v3_fixes
Please find the notification about this branch being updated (in the
case you have already fetched it).
>
> The biggest problem from Y2038 support point of view is with removing
> __time64_t from posix/bits/types.h
> (more explanation in the other mail).
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma@denx.de
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-24 22:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 11:20 [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t Lukasz Majewski
2019-02-27 11:20 ` [PATCH v2 2/2] Fix time/mktime.c and time/gmtime.c for gnulib compatibility Lukasz Majewski
2019-03-12 0:12 ` Paul Eggert
2019-03-06 11:31 ` [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t Lukasz Majewski
2019-03-12 0:11 ` Paul Eggert
2019-03-12 0:36 ` Joseph Myers
2019-03-17 22:48 ` Lukasz Majewski
2019-03-18 16:27 ` Joseph Myers
2019-03-19 10:53 ` Lukasz Majewski
2019-03-12 6:58 ` Lukasz Majewski
2019-03-18 21:23 ` Paul Eggert
2019-03-19 13:39 ` Lukasz Majewski
2019-03-19 23:12 ` Paul Eggert
2019-03-20 7:03 ` Lukasz Majewski
2019-03-22 21:49 ` Paul Eggert
2019-03-23 21:34 ` Lukasz Majewski
2019-03-24 22:17 ` Lukasz Majewski [this message]
2019-03-23 11:59 ` Lukasz Majewski
2019-03-27 20:06 ` Paul Eggert
2019-03-28 8:59 ` Lukasz Majewski
2019-03-28 16:09 ` Paul Eggert
2019-03-29 14:24 ` Lukasz Majewski
2019-03-29 21:10 ` Paul Eggert
2019-03-30 14:39 ` Lukasz Majewski
2019-04-01 20:17 ` Joseph Myers
2019-04-01 20:51 ` Lukasz Majewski
2019-03-28 16:34 ` Joseph Myers
[not found] ` <20190404120715.150a5d44@jawa>
[not found] ` <20190424135748.502c34af@jawa>
2019-04-28 22:45 ` Paul Eggert
2019-04-30 7:59 ` Lukasz Majewski
2019-04-30 16:25 ` Paul Eggert
2019-05-02 7:19 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190324231655.2ee728f1@jawa \
--to=lukma@denx.de \
--cc=eggert@cs.ucla.edu \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).