From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A659620248 for ; Sat, 23 Mar 2019 15:01:07 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; q=dns; s=default; b=N5/s Edrnncm+6H1cPpFRf8NnXTGq+6BvdzLbdWYhWzuBS3e8jcqsLFEn+YLVUI7MwqTN bbhGqIvAPYyKhYr6fKe0dwgYe8YxaDV8w7OEUKvesF/rIevmI8/PkomMieGbT/n2 8JHoVxH4LyP+cj+aY9jvS1MgI3koIT2lNgbqEpc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:in-reply-to; s=default; bh=BSnkn98cXU DVqVljdZqcDA3c+8s=; b=k8F1ITHfV6M7Hmh9b8u9diOTltT/2f2+ZwF3JOngBx afJ4e1PrWk9sa3p9+tocrgxnwGLq7Jypx88wQ3m7fyp2oBHG63LwSHu9HRngDJT+ kN5GDiBuyAqKOp/DtJwzpkgBsBrRMJBK2qPLlESjkMnCCnDnCUizhV+NRhhot8Qh E= Received: (qmail 5337 invoked by alias); 23 Mar 2019 15:00:55 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 4362 invoked by uid 89); 23 Mar 2019 15:00:45 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: smtpout1.mo528.mail-out.ovh.net Date: Sat, 23 Mar 2019 12:00:37 -0300 From: "Gabriel F. T. Gomes" To: Adhemerval Zanella CC: Subject: Re: [PATCH v2 4/6] powerpc: Use generic wcschr optimization Message-ID: <20190323150037.jojcge4xydlkrgmr@tereshkova.lan> References: <20190313140317.8894-1-adhemerval.zanella@linaro.org> <20190313140317.8894-4-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190313140317.8894-4-adhemerval.zanella@linaro.org> User-Agent: NeoMutt/20180716 X-Ovh-Tracer-Id: 5339298835860475593 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedutddrjeefgdejgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd On Wed, Mar 13 2019, Adhemerval Zanella wrote: > This patch removes the power6 wcschr optimization and use generic > implementation instead. Currently both power6 and power7 ifunc variant > resulting binary are essentially the same and the generic implementation > with unrolling loop set to 8 also results in similar performance. The patch looks good to me with the ChangeLog fixed (see below). Reviewed-by: Gabriel F. T. Gomes > * sysdeps/powerpc/Makefile [$(subdir) == wcsmbs] (CFLAGS-wcschr.c): > New rule. > * sysdeps/powerpc/power6/wcschr.c: Remove file. > * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-power6.c: > Likewise. > * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-power7.c: > Likewise. > * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr-ppc32.c: > Likewise. > * sysdeps/powerpc/powerpc32/power4/multiarch/wcschr.c: Likewise. > * sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c: Likewise. This file has not been removed, maybe you could just move it... > * sysdeps/powerpc/powerpc64/multiarch/wcschr-power6.c: Likewise. > * sysdeps/powerpc/powerpc64/multiarch/wcschr-power7.c: Likewise. > * sysdeps/powerpc/powerpc64/multiarch/wcschr-ppc64.c: Likewise. > * sysdeps/powerpc/powerpc64/multiarch/wcschr.c: Likewise. > * sysdeps/powerpc/powerpc64/power6/wcschr.c: Likewise. > * sysdeps/powerpc/powerpc32/power4/multiarch/Makefile > [$(subdir) == wcsmbs] (sysdeps_routines): Remove wcschr-power6 and > wcschr-power7. > (CFLAGS-wcschr-power7.c, CFLAGS-wcschr-power6.c): Remove rule. > * sysdeps/powerpc/powerpc64/multiarch/Makefile: Likewise. > * sysdeps/powerpc/powerpc32/power4/multiarch/ifunc-impl-list.c: > Remove wcschr optimizations. ... Here.