From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A29ED20248 for ; Tue, 19 Mar 2019 10:53:23 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=b1z03 Gws9HyZ8kg6APKWDl1vH6MBBrMOz7G0VTvMD2bC75wxkMnj82Kymtl5ZRytiexHi 9IfLFbkykC9YgJCuq3WB+pHqXv7P6MumBmZ8n7T7tY8WWnnrRLhndOaPueXuGYhs Wtn9ivt1Jd5s4l2nBVuIkKBhZ5xw7Cbdy1X0KM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type; s=default; bh=T/92ji1XlwU CmdrUE6yr2rkklNQ=; b=ow7HAKIdfMBVcu2P7fp/sXA5ob8Q8z5JTRvc/Ns649s hEs0ppy79zkmVsJrNac6yyltAGfTJKGkp3qNw1sIUO93Lou9EmwAL+0JZ+zQQ883 RwwWP+piuwJdgTxL/vJbcWhPFFu7Tds2ncjiUnD6mq6V994GWX7TcRxJw9RV1y30 = Received: (qmail 32050 invoked by alias); 19 Mar 2019 10:53:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 32039 invoked by uid 89); 19 Mar 2019 10:53:20 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-out.m-online.net Date: Tue, 19 Mar 2019 11:53:12 +0100 From: Lukasz Majewski To: Joseph Myers Cc: Paul Eggert , Subject: Re: [PATCH v2 1/2] Y2038: make __mktime_internal compatible with __time64_t Message-ID: <20190319115312.24e059b4@jawa> In-Reply-To: References: <20190227112042.1794-1-lukma@denx.de> <20190317234853.2d8cf98b@jawa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/4UzvZuYJt9dSefYeN9L+hgO"; protocol="application/pgp-signature" --Sig_/4UzvZuYJt9dSefYeN9L+hgO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Joseph, > On Sun, 17 Mar 2019, Lukasz Majewski wrote: >=20 > > Do you require following code in include/time.h for timelocal: > >=20 > > #if defined __USE_MISC > > # if defined(__REDIRECT) > > extern int __REDIRECT (timelocal, (struct tm *__tp), > > __mktime64) __THROW); > > # else > > # define timelocal __mktime64 > > # endif > > #endif =20 >=20 > include/time.h is an *internal* header, so should not need to test > __USE_* or use __REDIRECT. >=20 > Something like that would be appropriate in the *installed* header=20 > (time/time.h), under whatever __USE_* condition is set by > _TIME_BITS=3D64, but only at the later point where we're ready to add > support for _TIME_BITS=3D64 to the public headers and corresponding new > public symbol versions for the new ABIs. >=20 > By using something like that in the installed header you avoid any > need to define the name __timelocal64 anywhere. >=20 The distinction between internal and external set of headers was unclear for me. Thanks for clarification. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/4UzvZuYJt9dSefYeN9L+hgO Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAlyQyhgACgkQAR8vZIA0 zr21ggf5AfGwYXixqAxePzYn+ROrl6zHNpGmuyWvb/If4PVV3i8+N4DIF2+lxM41 FHCLEqFO74h/rAQxHRo2P5v/p8XoaaF7htgNhVRwS6Zw9daAKKa7pAezwyIJ6ixy Wrr5cfUWb2Mqld6yzH1EuXxdsHZS8NkwtOpYv303EWhfC8pS/8atCVsp63TgW3Go mRx0zt74Qr8q62pJj+wCUF+QAi0FeX1bAUImJa617J4uJLfGs4JLTlKaz7CpQhMC SR590RUoLyoi6t6DsljpXSYj0I8VQLVYQE83aJVAt/cLFBnmTnYt755lguv35FC5 T6NQznS7USeOG1xs+Si1FJLJbZxsyw== =lt9h -----END PGP SIGNATURE----- --Sig_/4UzvZuYJt9dSefYeN9L+hgO--