From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Cc: "Gabriel F . T . Gomes" <gabriel@inconstante.eti.br>
Subject: [PATCH v2 1/6] wcsmbs: Add wcscpy loop unroll option
Date: Wed, 13 Mar 2019 11:03:12 -0300 [thread overview]
Message-ID: <20190313140317.8894-1-adhemerval.zanella@linaro.org> (raw)
This allows an architecture the use the old generic implementation
and also set explicit loop unrolling.
Checked on aarch64-linux-gnu.
* include/loop_unroll.h: New file.
* wcsmbs/wcscpy (__wcscpy): Add option to use loop unrolling
besides generic implementation.
---
include/loop_unroll.h | 78 +++++++++++++++++++++++++++++++++++++++++++
wcsmbs/wcscpy.c | 19 +++++++++++
2 files changed, 97 insertions(+)
create mode 100644 include/loop_unroll.h
diff --git a/include/loop_unroll.h b/include/loop_unroll.h
new file mode 100644
index 0000000000..f40d375257
--- /dev/null
+++ b/include/loop_unroll.h
@@ -0,0 +1,78 @@
+/* Macro for explicit loop unrolling.
+ Copyright (C) 2019 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _LOOP_UNROLL_H
+#define _LOOP_UNROLL_H
+
+/* Loop unroll macro to be used for explicity force loop unrolling with a
+ configurable number or iterations. The idea is to make the loop unrolling
+ independent of whether compiler is able to unrolling through specific
+ optimizations options (-funroll-loops or -funroll-all-loops).
+
+ For instance, to implement strcpy with SRC being the source input and
+ DEST the destination buffer, it is expected the macro to be used in this
+ way:
+
+ #define ITERATION(index) \
+ ({ char c = *str++; *dest++ = c; c != '\0' })
+
+ while (1)
+ UNROLL_REPEAT (4, ITERATION)
+
+ The loop will be manually unrolled 4 times. Another option is to do
+ the index update after the tests:
+
+ #define ITERATION(index) \
+ ({ char c = *(str + index); *(dest + index) = c; c != '\0' })
+ #define UPDATE(n) \
+ str += n; dst += n
+
+ while (1)
+ UNROLL_REPEAT_UPDATE (4, ITERATION, UPDATE)
+
+ The loop will be manually unrolled 4 times and the SRC and DEST pointers
+ will be update only after last iteration.
+
+ Currently both macros unrolls the loop 8 times at maximum. */
+
+#define UNROLL_REPEAT_1(X) if (!X(0)) break;
+#define UNROLL_REPEAT_2(X) UNROLL_REPEAT_1(X) if (!X(1)) break;
+#define UNROLL_REPEAT_3(X) UNROLL_REPEAT_2(X) if (!X(2)) break;
+#define UNROLL_REPEAT_4(X) UNROLL_REPEAT_3(X) if (!X(3)) break;
+#define UNROLL_REPEAT_5(X) UNROLL_REPEAT_4(X) if (!X(4)) break;
+#define UNROLL_REPEAT_6(X) UNROLL_REPEAT_5(X) if (!X(5)) break;
+#define UNROLL_REPEAT_7(X) UNROLL_REPEAT_6(X) if (!X(6)) break;
+#define UNROLL_REPEAT_8(X) UNROLL_REPEAT_7(X) if (!X(7)) break;
+
+#define UNROLL_EXPAND(...) __VA_ARGS__
+
+#define UNROLL_REPEAT__(N, X) UNROLL_EXPAND(UNROLL_REPEAT_ ## N) (X)
+#define UNROLL_REPEAT_(N, X) UNROLL_REPEAT__ (N, X)
+
+#define UNROLL_REPEAT(N, X) \
+ (void) ({ \
+ UNROLL_REPEAT_(UNROLL_EXPAND(N), X); \
+ })
+
+#define UNROLL_REPEAT_UPDATE(N, X, U) \
+ (void) ({ \
+ UNROLL_REPEAT_ (UNROLL_EXPAND(N), X); \
+ UPDATE (N); \
+ })
+
+#endif
diff --git a/wcsmbs/wcscpy.c b/wcsmbs/wcscpy.c
index 6fb2969513..8e8719744e 100644
--- a/wcsmbs/wcscpy.c
+++ b/wcsmbs/wcscpy.c
@@ -17,6 +17,7 @@
<http://www.gnu.org/licenses/>. */
#include <wchar.h>
+#include <loop_unroll.h>
#ifdef WCSCPY
@@ -27,7 +28,25 @@
wchar_t *
__wcscpy (wchar_t *dest, const wchar_t *src)
{
+#ifndef UNROLL_NTIMES
return __wmemcpy (dest, src, __wcslen (src) + 1);
+#else
+ /* Some architectures might have costly tail function call (powerpc
+ for instance) where wmemcpy call overhead for smalls sizes might
+ be costly than just unroll the main loop. */
+ wchar_t *wcp = dest;
+
+#define ITERATION(index) \
+ ({ \
+ wchar_t c = *src++; \
+ *wcp++ = c; \
+ c != L'\0'; \
+ })
+
+ while (1)
+ UNROLL_REPEAT(UNROLL_NTIMES, ITERATION);
+ return dest;
+#endif
}
#ifndef WCSCPY
weak_alias (__wcscpy, wcscpy)
--
2.17.1
next reply other threads:[~2019-03-13 14:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 14:03 Adhemerval Zanella [this message]
2019-03-13 14:03 ` [PATCH v2 2/6] powerpc: Use generic wcscpy optimization Adhemerval Zanella
2019-03-23 14:56 ` Gabriel F. T. Gomes
2019-03-13 14:03 ` [PATCH v2 3/6] wcsmbs: Use loop_unroll on wcschr Adhemerval Zanella
2019-03-23 15:00 ` Gabriel F. T. Gomes
2019-03-13 14:03 ` [PATCH v2 4/6] powerpc: Use generic wcschr optimization Adhemerval Zanella
2019-03-23 15:00 ` Gabriel F. T. Gomes
2019-03-13 14:03 ` [PATCH v2 5/6] wcsmbs: Use loop_unroll on wcsrchr Adhemerval Zanella
2019-03-23 15:00 ` Gabriel F. T. Gomes
2019-03-13 14:03 ` [PATCH v2 6/6] powerpc: Use generic wcscpy optimization Adhemerval Zanella
2019-03-23 15:01 ` Gabriel F. T. Gomes
2019-03-23 15:00 ` [PATCH v2 1/6] wcsmbs: Add wcscpy loop unroll option Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313140317.8894-1-adhemerval.zanella@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=gabriel@inconstante.eti.br \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).