From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id EF3DA20248 for ; Fri, 8 Mar 2019 20:44:31 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= bPi8UXfsBc01GOCfYgC6K0zwij/vVXiEaKUNZexRUmgp5E6yheYkQvl/v/FFdPY0 C5MjZBWqJuiLf7fFkfYb/njwoaIaltWKgqofnrp9hzVaboz7MX5BRx5SPY3pl6U9 OtCLzCHfCm1SRxUTSyNg92jF6KRHwtmKK4MQW3MawKw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:to:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=XH9YbG LUxUD864q+qvqUMf5ejdY=; b=CkgWav2SrJSOQ6R3MDRyikjoC3bgZIgLqSXBmR tv9VGsMMWHjY9dD/pjRXQ8LW3DWrkld9OOyelFkNTBT62rXqRPzWmJD5A9jATN6m EA9WGYUiurXC6rnt5bqp/z0Suy7KDJZBrKI+cBRVP3/A69Pbyb6nBNPhy5t20yNl 7yO0Y= Received: (qmail 16590 invoked by alias); 8 Mar 2019 20:44:29 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 16580 invoked by uid 89); 8 Mar 2019 20:44:28 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mx1.redhat.com Date: Fri, 08 Mar 2019 21:44:23 +0100 To: libc-alpha@sourceware.org Subject: [PATCH] nss_dns: Do not call res_dnok in getnetby* implementation User-Agent: Heirloom mailx 12.5 7/5/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20190308204424.0744F80DD6B5@oldenburg2.str.redhat.com> From: Florian Weimer The argument to res_dnok was produced by ns_name_ntop, so it is a syntactically valid domain name which, in textual format, only consists of printable characters. Therefore, the res_dnok check always passes. 2019-03-08 Florian Weimer * resolv/nss_dns/dns-network.c (getanswer_r): Do not call res_dnok. diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c index 4b81b1bfdc..4617b165db 100644 --- a/resolv/nss_dns/dns-network.c +++ b/resolv/nss_dns/dns-network.c @@ -348,7 +348,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, if (n > 0 && bp[0] == '.') bp[0] = '\0'; - if (n < 0 || res_dnok (bp) == 0) + if (n < 0) break; cp += n; @@ -382,7 +382,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, n = -1; } - if (n < 0 || !res_hnok (bp)) + if (n < 0) { /* XXX What does this mean? The original form from bind returns NULL. Incrementing cp has no effect in any case.