From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C87F91F453 for ; Tue, 22 Jan 2019 01:41:15 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:from:date:to:cc:subject:in-reply-to :references:mime-version:content-type; q=dns; s=default; b=SZWBU hIAOoeD5iM/GrDsalnG/BP++fP1vdYc4N2dCVLL5V0004zuu/50M+3iZ0P0Q48sc 0PLZlrhmGpN0j06C3OlxSO6Y1ggESFDjFw5KHKrzlf11WPzbmU+1XaiepYoOGwul krjG/JeU9hxd3uAfPW+jd2d5ESLwZaEnaYp63w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:from:date:to:cc:subject:in-reply-to :references:mime-version:content-type; s=default; bh=jGIJxzlUj/T uDLi0azPuDRw4a9w=; b=posYodJur7dXE98d6PIRCB0TOUkjWBFkGhyAZsThT1h NZ+VbVjvvVilJVypyR3esCIzVe0bfQlpN7PQdUhSZQpDXcpBzO2qAtKeY69Gh7wm KN/b72BPlp7RnlXMzIg7xhv+LnVyvg+7z2zhcnNdwq59CPrDi/Xp6cDBQ/0LBtXk = Received: (qmail 61635 invoked by alias); 22 Jan 2019 01:41:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 61614 invoked by uid 89); 22 Jan 2019 01:41:11 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail.linet.jp Message-Id: <201901220140.AA04205@tamuki.linet.gr.jp> From: TAMUKI Shoichi Date: Tue, 22 Jan 2019 10:40:24 +0900 To: Rafal Luzynski Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v8 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096] In-Reply-To: <428627917.497184.1548091409555@poczta.nazwa.pl> References: <428627917.497184.1548091409555@poczta.nazwa.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Hello Rafal, From: Rafal Luzynski Subject: Re: [PATCH v8 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #24096] Date: Mon, 21 Jan 2019 18:23:29 +0100 (CET) > > +If the @code{E} modifier is specified (@code{%EC}), instead produces > > +the name of the period for the year (e.g. an era name) in the locale's > > +alternative calendar. > > + > > "e.g." should be "e.g.@:". It is important to use "@:" to mark that this > dot is not the end of a sentence and thus control the space width. OK, I will fix this in the next patch. > > + int yr_spec = 0; /* Override padding for "%Ey". */ > > I think that you don't need this variable now. > > > - return __strftime_internal (s, maxsize, format, tp, &tzset_called > > + return __strftime_internal (s, maxsize, format, tp, yr_spec, > > Consequently, you can pass 0 instead of yr_spec here. Exactly you are right. I will fix this in the next patch. > I don't quote the rest of the code because I believe it is OK. > > Please verify if my suggestions are correct, I am unable to test now. The test is OK. I attach the result to this mail. Regards, TAMUKI Shoichi