[PATCH] SH: statx is missing in the kernel

[PATCH] SH: statx is missing in the kernel

[Romain Naour]

__NR_statx is not defined by the kernel headers and __ASSUME_STATX is
defined since kernel 4.11.

__ASSUME_STATX must be undefined until SH kernel support statx.

Fixes:
../sysdeps/unix/sysv/linux/statx.c:41:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 ChangeLog                                    | 5 +++++
 sysdeps/unix/sysv/linux/sh/kernel-features.h | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 03dbce43d9..23db06819c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-23  Romain Naour  <romain.naour@gmail.com>  (tiny change)
+
+	* sysdeps/unix/sysv/linux/sh/kernel-features.h
+	(__ASSUME_STATX): Undef.
+
 2018-07-20  Joseph Myers  <joseph@codesourcery.com>
 
 	* scripts/build-many-glibcs.py (Context.checkout): Default
diff --git a/sysdeps/unix/sysv/linux/sh/kernel-features.h b/sysdeps/unix/sysv/linux/sh/kernel-features.h
index 05b7dcd037..9b06ffe284 100644
--- a/sysdeps/unix/sysv/linux/sh/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/sh/kernel-features.h
@@ -56,4 +56,7 @@
 # undef __ASSUME_RENAMEAT2
 #endif
 
+/* Support for statx is not available yet for SH.  */
+# undef __ASSUME_STATX
+
 #endif
-- 
2.14.4

Re: [PATCH] SH: statx is missing in the kernel

[Florian Weimer]

[-- Attachment #1: Type: text/plain, Size: 499 bytes --]

On 07/23/2018 08:05 PM, Romain Naour wrote:
> __NR_statx is not defined by the kernel headers and __ASSUME_STATX is
> defined since kernel 4.11.
> 
> __ASSUME_STATX must be undefined until SH kernel support statx.

Carlos, I would like to check in the attached patch for 2.28.  I 
compile-tested this with build-many-glibcs.py against a 4.11 kernel tree 
with --enable-kernel=4.13.

I'm preparing another patch for alpha, which still has to undergo 
testing on kernel 4.13 sources.

Thanks,
Florian

[-- Attachment #2: sh.patch --]
[-- Type: text/x-patch, Size: 645 bytes --]

Subject: [PATCH] sh: Do not define __ASSUME_STATX
To: libc-alpha@sourceware.org

2018-07-24  Florian Weimer  <fweimer@redhat.com>

	* sysdeps/unix/sysv/linux/sh/kernel-features.h (__ASSUME_STATX):
	Undefine.  Suggested by Romain Naour <romain.naour@gmail.com>.

diff --git a/sysdeps/unix/sysv/linux/sh/kernel-features.h b/sysdeps/unix/sysv/linux/sh/kernel-features.h
index 05b7dcd037..b8ccb01518 100644
--- a/sysdeps/unix/sysv/linux/sh/kernel-features.h
+++ b/sysdeps/unix/sysv/linux/sh/kernel-features.h
@@ -56,4 +56,7 @@
 # undef __ASSUME_RENAMEAT2
 #endif
 
+/* sh does not support the statx system call.  */
+#undef __ASSUME_STATX
+
 #endif

Re: [PATCH] SH: statx is missing in the kernel

[Carlos O'Donell]

On 07/24/2018 02:51 PM, Florian Weimer wrote:
> On 07/23/2018 08:05 PM, Romain Naour wrote:
>> __NR_statx is not defined by the kernel headers and __ASSUME_STATX
>> is defined since kernel 4.11.
>> 
>> __ASSUME_STATX must be undefined until SH kernel support statx.
> 
> Carlos, I would like to check in the attached patch for 2.28.  I
> compile-tested this with build-many-glibcs.py against a 4.11 kernel
> tree with --enable-kernel=4.13.

OK for 2.28.

Thank you for looking at this!

> I'm preparing another patch for alpha, which still has to undergo
> testing on kernel 4.13 sources.

OK, TO: me when that one is ready.

Cheers,
Carlos.

Re: [PATCH] SH: statx is missing in the kernel

[Christoph Hellwig]

Dear linux-sh maintainers,

can we make sure to at least wire statx for 4.19?  That's not going
to immediately solve the glibc problem, but at least it won't be
prolonged.

On Tue, Jul 24, 2018 at 08:51:25PM +0200, Florian Weimer wrote:
> On 07/23/2018 08:05 PM, Romain Naour wrote:
>> __NR_statx is not defined by the kernel headers and __ASSUME_STATX is
>> defined since kernel 4.11.
>>
>> __ASSUME_STATX must be undefined until SH kernel support statx.
>
> Carlos, I would like to check in the attached patch for 2.28.  I 
> compile-tested this with build-many-glibcs.py against a 4.11 kernel tree 
> with --enable-kernel=4.13.
>
> I'm preparing another patch for alpha, which still has to undergo testing 
> on kernel 4.13 sources.
>
> Thanks,
> Florian

> Subject: [PATCH] sh: Do not define __ASSUME_STATX
> To: libc-alpha@sourceware.org
> 
> 2018-07-24  Florian Weimer  <fweimer@redhat.com>
> 
> 	* sysdeps/unix/sysv/linux/sh/kernel-features.h (__ASSUME_STATX):
> 	Undefine.  Suggested by Romain Naour <romain.naour@gmail.com>.
> 
> diff --git a/sysdeps/unix/sysv/linux/sh/kernel-features.h b/sysdeps/unix/sysv/linux/sh/kernel-features.h
> index 05b7dcd037..b8ccb01518 100644
> --- a/sysdeps/unix/sysv/linux/sh/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/sh/kernel-features.h
> @@ -56,4 +56,7 @@
>  # undef __ASSUME_RENAMEAT2
>  #endif
>  
> +/* sh does not support the statx system call.  */
> +#undef __ASSUME_STATX
> +
>  #endif

---end quoted text---