Re: [PATCH] New configure option --disable-crypt.

["Dmitry V. Levin" <ldv@altlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

On Thu, Jun 28, 2018 at 08:23:18PM +0200, Florian Weimer wrote:
> On 06/28/2018 07:33 PM, Dmitry V. Levin wrote:
> > On Mon, Jun 25, 2018 at 03:44:03PM +0200, Florian Weimer wrote:
> > [...]
> >> +@item --disable-crypt
> >> +Do not install the passphrase-hashing library @file{libcrypt} or the
> >> +header file @file{crypt.h}.  @file{unistd.h} will still declare the
> >> +function @code{crypt}, as required by POSIX@.  Using this option does
> >> +not change the set of programs that may need to be linked with
> >> +@option{-lcrypt}; it only means that @theglibc{} will not provide that
> >> +library.
> > 
> > Given that the first commit of the series moves the declaration of crypt()
> > from __USE_XOPEN to __USE_MISC, this reference to POSIX becomes less obvious.
> 
> Well spotted.  What about this?
> 
> @item --disable-crypt
> Do not install the passphrase-hashing library @file{libcrypt} or the
> header file @file{crypt.h}.  @file{unistd.h} will still declare the
> function @code{crypt}.  Using this option does not change the set of
> programs that may need to be linked with @option{-lcrypt}; it only
> means that @theglibc{} will not provide that library.

Thanks, this edition is less cryptic.

> What do you think about the other patches in the series?
> 
> https://sourceware.org/ml/libc-alpha/2018-06/msg00723.html
> https://sourceware.org/ml/libc-alpha/2018-06/msg00724.html
> https://sourceware.org/ml/libc-alpha/2018-06/msg00725.html
> 
> Do you consider them ready to commit?

Yes, I think they are good enough to be committed, further polishing
could be continued afterwards if necessary.


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]