unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] New configure option --disable-crypt.
Date: Thu, 28 Jun 2018 20:33:35 +0300	[thread overview]
Message-ID: <20180628173335.GA16038@altlinux.org> (raw)
In-Reply-To: <20180625134403.2B6DC43994575@oldenburg.str.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

On Mon, Jun 25, 2018 at 03:44:03PM +0200, Florian Weimer wrote:
[...]
> +@item --disable-crypt
> +Do not install the passphrase-hashing library @file{libcrypt} or the
> +header file @file{crypt.h}.  @file{unistd.h} will still declare the
> +function @code{crypt}, as required by POSIX@.  Using this option does
> +not change the set of programs that may need to be linked with
> +@option{-lcrypt}; it only means that @theglibc{} will not provide that
> +library.

Given that the first commit of the series moves the declaration of crypt()
from __USE_XOPEN to __USE_MISC, this reference to POSIX becomes less obvious.

Besides that, the change looks fine.


-- 
ldv

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  parent reply	other threads:[~2018-06-28 17:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 13:44 [PATCH] New configure option --disable-crypt Florian Weimer
2018-06-25 13:47 ` Florian Weimer
2018-06-25 14:20 ` Dmitry V. Levin
2018-06-25 14:28   ` Florian Weimer
2018-06-28 17:33 ` Dmitry V. Levin [this message]
2018-06-28 18:23   ` Florian Weimer
2018-06-28 21:20     ` Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628173335.GA16038@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).