From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Gabriel F. T. Gomes" Newsgroups: gmane.comp.lib.glibc.alpha Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions Date: Mon, 26 Feb 2018 09:28:17 -0300 Message-ID: <20180226092817.2fe8d745@keller.br.ibm.com> References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <20180208114901.7c12242e@keller> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519647993 31226 195.159.176.226 (26 Feb 2018 12:26:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 12:26:33 +0000 (UTC) Cc: To: Adhemerval Zanella Original-X-From: libc-alpha-return-90573-glibc-alpha=m.gmane.org@sourceware.org Mon Feb 26 13:26:29 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; q=dns; s=default; b=WegnS0dOq2C0UEouZiKBkUoRHFO9q/+y5H+CvcXLy4g UqjaUGompFeoVJ6W7EmVLNQg1LdpHqOp+lJarv4+BTmWGvRMqejogSlIeBdxgjPw y4jnvQ9lwlL4SJ+3rQRRKn3+kQmLrLfhb2GndTtrVk/3GY4DTcuwFuNpYK6dPIpQ = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; s=default; bh=bcKwWulHJSPFoFu0G0DOlxQ1TCc=; b=ogcK+LsWuSwtXFw8x pnomMLX3LInactFKnEfU3eqCQIXiVWUg7LPVYauCNm+CbClCgc+5t3D3GezbEl1N MXbBe5uNgYbf4PgAscsj9XL5aTAiwn7cQXo88t0HQROCaOXzOBBft9cZPPAn0J+J nhlAiauoOavRzdH9sxiKmmTZiw= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=H*r:172.16.2, Destroy, novice, HX-Envelope-From:sk:gabriel X-HELO: mo19.mail-out.ovh.net In-Reply-To: X-ClientProxiedBy: EX1.emp.local (172.16.2.1) To EX2.emp.local (172.16.2.2) X-Ovh-Tracer-Id: 18260126166056554185 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtfedriedugdefjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Xref: news.gmane.org gmane.comp.lib.glibc.alpha:82905 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqHrQ-0007f7-H8 for glibc-alpha@blaine.gmane.org; Mon, 26 Feb 2018 13:26:28 +0100 Received: (qmail 48820 invoked by alias); 26 Feb 2018 12:28:31 -0000 Received: (qmail 48799 invoked by uid 89); 26 Feb 2018 12:28:30 -0000 On Fri, 09 Feb 2018, Adhemerval Zanella wrote: >On 08/02/2018 11:49, Gabriel F. T. Gomes wrote: >> On Fri, 02 Feb 2018, Adhemerval Zanella wrote: >> >>> -/* We do not support C11 . */ >>> -#define __STDC_NO_THREADS__ 1 >> >> I don't know if that actually matters, but should you wait until the other >> patches in this series (at least patch 2) are in before removing this >> definition? > >I do not have a strong opinion about when to remove __STDC_NO_THREADS__, since >my idea is first get all patches reviewed and acked before actually commit then. Fair enough. I also reviewed the other patches in this set, and I don't have further comments other than the cosmetic bit below. (Since I'm definitely *not* an expert at threads, I only checked against the standard and it looks good to me. So, please read this review as one from a novice) On patch 4: >+/* Destroy condition variable pointed by __cond and free all of its >+ resources. */ >+extern void cnd_destroy (cnd_t *__COND); ~~~~~~ Only here, the parameter name is in uppercase (and the comment in lowercase). Any special reason to do so?