From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A138C1F55B for ; Mon, 1 Jun 2020 14:13:35 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 918713851C09; Mon, 1 Jun 2020 14:13:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 918713851C09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591020814; bh=MFJlvaUisxy/yet7esnXN2QUyeeQV7ENruLKR5zgMl0=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Pij6PdWEneXPHjoFHR+P8O2UoNjYYB3iMOgGSBEZoZ9HrsYtgFa/BA8FqM89mqQIQ AgQBu8VALtuUsfXgdr4yaINnuZjG5J4C3f2ShM7q9Qn4ybud7quMJdy6Y4YPhGIAf2 SNZMmNpV0vErqUpbqB6AZyfxDvmlTDa38hr0G0/I= Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) by sourceware.org (Postfix) with ESMTPS id E8A303851C06 for ; Mon, 1 Jun 2020 14:13:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E8A303851C06 Received: by mail-qt1-x841.google.com with SMTP id x29so7761972qtv.4 for ; Mon, 01 Jun 2020 07:13:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=MFJlvaUisxy/yet7esnXN2QUyeeQV7ENruLKR5zgMl0=; b=irkViPCCBA6/ZhiqOISDyUp4taD7RGt6ZfkzUCa0grkFHRq3Hj5onbipt2tU1S3V4h vqGiClvFdYA0UC+IYrkxrACmUFtRblcbkJDcrcDh2hcEcQfBVT9DDRGqYZQmo8K4yOy/ iqvQqnijBTNg373zmcny06KrGjdmnV+ROke9m7DdRkjVAalwB7DPWr2O89CuZBC2cMI7 rS7byxnJpE97cGBSNEpP/JB5dFerooTUjEF8fQJpzmUJ0Tn8/IOFHYWOsp2kiQ0+pdkE VBDArfL6IMOVYISG/JlevMGPUBk1JAALuZwMQ3DadJgGxvN/5b2iZ6TlYSnG5KvvXbuD YfYw== X-Gm-Message-State: AOAM530DQ+ni4SDz4LSnjeJqPXbWQxZUC4qMfp4haXFR3oKfmvrXjiNV Io9c2g2tjWNmj9TvpAjuernXCKB3L1Q= X-Google-Smtp-Source: ABdhPJwbEy8OnVI3r417zhKR861VNpdBevYQm9wThySnJZGlg2d5Lwa/sJGbKs9FJAPGnzfttl6RMQ== X-Received: by 2002:ac8:3876:: with SMTP id r51mr21088315qtb.89.1591020811227; Mon, 01 Jun 2020 07:13:31 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id c201sm1322127qkg.57.2020.06.01.07.13.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 07:13:30 -0700 (PDT) Subject: Re: [PATCH 2/5] iee754: prvoide gcc builtins based generic sqrt functions To: Vineet Gupta , libc-alpha@sourceware.org References: <20200530020047.5490-1-vgupta@synopsys.com> <20200530020047.5490-3-vgupta@synopsys.com> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <1f8c98ba-481c-1463-29ff-c0dec7add324@linaro.org> Date: Mon, 1 Jun 2020 11:13:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200530020047.5490-3-vgupta@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: linux-snps-arc@lists.infradead.org Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 29/05/2020 23:00, Vineet Gupta wrote: LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/generic/math-use-builtins.h | 3 +++ > sysdeps/ieee754/dbl-64/e_sqrt.c | 6 ++++++ > sysdeps/ieee754/flt-32/e_sqrtf.c | 6 ++++++ > 3 files changed, 15 insertions(+) > > diff --git a/sysdeps/generic/math-use-builtins.h b/sysdeps/generic/math-use-builtins.h > index 8a39ef58bc95..fc724c824a17 100644 > --- a/sysdeps/generic/math-use-builtins.h > +++ b/sysdeps/generic/math-use-builtins.h > @@ -60,4 +60,7 @@ > # define USE_COPYSIGNF128_BUILTIN 0 > #endif > > +#define USE_SQRT_BUILTIN 0 > +#define USE_SQRTF_BUILTIN 0 > + > #endif /* math-use-builtins.h */ Ok. > diff --git a/sysdeps/ieee754/dbl-64/e_sqrt.c b/sysdeps/ieee754/dbl-64/e_sqrt.c > index d42a1a4eb6e9..518a8ae5cdaf 100644 > --- a/sysdeps/ieee754/dbl-64/e_sqrt.c > +++ b/sysdeps/ieee754/dbl-64/e_sqrt.c > @@ -41,6 +41,7 @@ > #include > #include > #include > +#include > > /*********************************************************************/ > /* An ultimate sqrt routine. Given an IEEE double machine number x */ Ok. > @@ -50,6 +51,10 @@ > double > __ieee754_sqrt (double x) > { > +#if USE_SQRT_BUILTIN > + return __builtin_sqrt (x); > +#else > + /* Use generic implementation. */ > static const double > rt0 = 9.99999999859990725855365213134618E-01, > rt1 = 4.99999999495955425917856814202739E-01, > @@ -138,6 +143,7 @@ __ieee754_sqrt (double x) > return (x - x) / (x - x); /* sqrt(-ve)=sNaN */ > return 0x1p-256 * __ieee754_sqrt (x * 0x1p512); > } > +#endif /* ! USE_SQRT_BUILTIN */ > } > #ifndef __ieee754_sqrt > libm_alias_finite (__ieee754_sqrt, __sqrt) Ok. > diff --git a/sysdeps/ieee754/flt-32/e_sqrtf.c b/sysdeps/ieee754/flt-32/e_sqrtf.c > index b339444301aa..68fc80e1e1ee 100644 > --- a/sysdeps/ieee754/flt-32/e_sqrtf.c > +++ b/sysdeps/ieee754/flt-32/e_sqrtf.c > @@ -16,12 +16,17 @@ > #include > #include > #include > +#include > > static const float one = 1.0, tiny=1.0e-30; > > float > __ieee754_sqrtf(float x) > { > +#if USE_SQRTF_BUILTIN > + return __builtin_sqrtf (x); > +#else > + /* Use generic implementation. */ > float z; > int32_t sign = (int)0x80000000; > int32_t ix,s,q,m,t,i; > @@ -83,6 +88,7 @@ __ieee754_sqrtf(float x) > ix += (m <<23); > SET_FLOAT_WORD(z,ix); > return z; > +#endif /* ! USE_SQRTF_BUILTIN */ > } > #ifndef __ieee754_sqrtf > libm_alias_finite (__ieee754_sqrtf, __sqrtf) > Ok.