From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A99481F8C8 for ; Mon, 20 Sep 2021 12:55:12 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D0379385842E for ; Mon, 20 Sep 2021 12:55:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0379385842E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632142511; bh=YM+yCbxyUUFN1D/YeDU3IHeQ5vIT7jgvC2eqDpgPVNw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Vmoy2dergRmNH5zwZNpAavrEbBZTPIT4gMy+ayc04koHaCc+obtnUFDZJyw0pCv3w e8/VaIQ2veDsJGcGeVeIiIPqG037wzI/3k/DptJMf/WV3GnffB9rXeeXLlUsw9NCYM dzA3X57Am6CI/TfJbCIL3PyUcS5Va0gRBblCqXQA= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C44593858C60 for ; Mon, 20 Sep 2021 12:54:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C44593858C60 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-pIFgJs0DME-bHL9c9mpcXw-1; Mon, 20 Sep 2021 08:54:51 -0400 X-MC-Unique: pIFgJs0DME-bHL9c9mpcXw-1 Received: by mail-qk1-f198.google.com with SMTP id p23-20020a05620a22f700b003d5ac11ac5cso138316740qki.15 for ; Mon, 20 Sep 2021 05:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=YM+yCbxyUUFN1D/YeDU3IHeQ5vIT7jgvC2eqDpgPVNw=; b=JsUZ2IXEsszSqr9q+UNMWmRf4u67ra/6ugJRCUbUd0EMAPWConiTyNSARB6d5peIe+ CEnIg5IjU3FBNNFR3WOubHElqvBJIl3tiONfcv2gz4IpsbpsULiQaxN9NudcNX6t1WCS ea9hzitK+53LWzDAHqKGO+JB/bz5y1HXWXkNnlT0hXtwKjbVOpMDFonqF/yd7TpFJocW spiG2RqZPWW+RpMhq6OIGsAqL9ZVFYA64yS85uetVLxrehnKFl/RjT+slc5PqXbRTfuW HeTcS8s0+PlDaJ31ohDmWbv5UCueB3cFuYG8piqaTdIbjaYmjCaSwejacKfc3HRGp1u5 onJw== X-Gm-Message-State: AOAM531yx5RtvubAmYSgfXtrgJitfJf1rHfRFo1OqP56J8Vosx5/Ze5s 4yF6kXoqTcvelmp03T5/prsWap3K+HbSNVg0R02qtWdKbZmNdylv1rcyXjxneQc8ySRNdz8PSQ8 xyYWF831NY03ODdjYMQvn X-Received: by 2002:a37:aa8d:: with SMTP id t135mr5323835qke.370.1632142490749; Mon, 20 Sep 2021 05:54:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzP+6MSkghziVd4o9NEHCEsdhcJusqQlA01CprHNTU0gHyFtZvbGT6KbPVtgSjFkFxQivSBlQ== X-Received: by 2002:a37:aa8d:: with SMTP id t135mr5323816qke.370.1632142490569; Mon, 20 Sep 2021 05:54:50 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id r139sm9624380qke.84.2021.09.20.05.54.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 05:54:50 -0700 (PDT) Message-ID: <1f64c97e-c083-244e-609b-d2260ab982c3@redhat.com> Date: Mon, 20 Sep 2021 08:54:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v12 1/2] Add 'codepoint_collation' support for LC_COLLATE. To: Matheus Castanho References: <20210906154336.610973-1-carlos@redhat.com> <20210906154336.610973-2-carlos@redhat.com> <878s097h8m.fsf@linux.ibm.com> <878rzrwgwa.fsf@linux.ibm.com> Organization: Red Hat In-Reply-To: <878rzrwgwa.fsf@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Cc: Florian Weimer , libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 9/20/21 08:49, Matheus Castanho wrote: > > Carlos O'Donell writes: > >> On 9/6/21 1:20 PM, Matheus Castanho wrote: >>> In file included from C-collate.c:22: >>> C-collate-seq.c:58:42: error: expected ‘,’ before ‘)’ token >>> _Static_assert (sizeof (collseqmb) == 256); >>> ^ >> >> Which version of gcc? I assume gcc 8.x? Which distro? I know Florian >> fixed this, but I'm curious what you're using. >> >> So DJ and I just talked about how we would catch this in CI/CD, but >> we'd have to run fairly old unsupported Fedora to test this, so we'd >> have to do something different. > > Sorry for the delay. One case where I saw it was using GCC from Debian > 10: > > $ gcc --version > gcc (Debian 8.3.0-6) 8.3.0 > [...] Yea, so that's old enough that it would trigger the failure. Thanks, Florian fixed this with commit c9fef4b7d1d0f2dad192c74f06102752247677a9, and we shouldn't regress again thanks to the requirement for 2 arguments. -- Cheers, Carlos.