From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, PDS_RDNS_DYNAMIC_FP,RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AE96E1F601 for ; Tue, 6 Dec 2022 17:51:02 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="JfCd3YWU"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B0703842314 for ; Tue, 6 Dec 2022 17:50:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B0703842314 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670349059; bh=nFoJ6JuMXDllVK7clYsINAsagTGHQHoZBhyj5g5pIbc=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JfCd3YWUSVoIWvM9pLxXMjigvmVdq2dAeckGkJD7KeoR0paOTkx+25NXKiU8ycTo1 9piV3z8GEIR3fyr59z6ljBe/tfGpBU/Z4686FqUV3ZNYhVPuEj9+8wjIK+uT9KMM0p xre/7VgMPmQxbujU3GCCH+pONmWvym5avqhxf7Vk= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2DBF33842324 for ; Tue, 6 Dec 2022 17:50:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DBF33842324 Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-369-faEkrIzpMGmlD9X1AH7I6A-1; Tue, 06 Dec 2022 12:50:37 -0500 X-MC-Unique: faEkrIzpMGmlD9X1AH7I6A-1 Received: by mail-il1-f198.google.com with SMTP id e9-20020a056e020b2900b003036757d5caso4187021ilu.10 for ; Tue, 06 Dec 2022 09:50:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nFoJ6JuMXDllVK7clYsINAsagTGHQHoZBhyj5g5pIbc=; b=igKRpWYh2mzGmqEvT+DdWpXfjYCnoE72Rdi6wLjtM38N6o8hYhBDIz3PJTGEJsHyXW T6rBFRtJ5PGsXeLcW75qJjkYEbbmujAhyicBL/o1RWW/W6NEIvXhTRoP+jPJSY8sZiYA RH8LuYbaii1iW5X9FytPc/P8QYN5ZZMX/D/cZ16ZKJdubY3jMAz1mXGlEWRDSit8dTvV k6QNvuzJ66xwtyl7TCbKEzWozNbqZ/wvfsb5JaleqaBbTVIC8im+eXDf7cklGAV6k5YY Q3pWMYKtdSSLIibv1etJLv25cB5qAtuCc2PHmD647DUsdIP/t8Zm/RqNJ8PWrEf9MEvO FgRw== X-Gm-Message-State: ANoB5pn+rVUngUeL5fAITakLZHtcSX653MYlGFvF/uLsnVIv/fYTqL7H 6MnMAmiC6jGNoSDI+J81IZf4tvc5R/mN36KxTQhcCiwNqzH+zPEbUVqI7MAVmcSl/HIkBCZnPWE EmpFXKo6oHFe0QUkl3dzd X-Received: by 2002:a02:914b:0:b0:363:b3c4:5c47 with SMTP id b11-20020a02914b000000b00363b3c45c47mr33255313jag.237.1670349036782; Tue, 06 Dec 2022 09:50:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf67zYCMzd+KauYgl8ciS7xoL4qJUKp42vZh/J2RTdc13obknIgn7609Gqmm3QVaNSUcKdNkpQ== X-Received: by 2002:a02:914b:0:b0:363:b3c4:5c47 with SMTP id b11-20020a02914b000000b00363b3c45c47mr33255310jag.237.1670349036555; Tue, 06 Dec 2022 09:50:36 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id w7-20020a92d2c7000000b003027f923d29sm6292219ilg.39.2022.12.06.09.50.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 09:50:36 -0800 (PST) Message-ID: <1f02c8b4-1572-fa0f-eaa1-81f1a098c75d@redhat.com> Date: Tue, 6 Dec 2022 12:50:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 30/30] Linux: Remove generic Implies To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-31-adhemerval.zanella@linaro.org> Organization: Red Hat In-Reply-To: <20221019221433.1082017-31-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > The default Linux implementation already handled the Linux generic > ABIs interface used on newer architectures, so there is no need to > Imply the generic any longer. Agreed. LGTM. No regressions on x86_64 and i686. Reviewed-by: Carlos O'Donell Tested-by: Carlos O'Donell > --- > sysdeps/unix/sysv/linux/aarch64/Implies | 1 - > sysdeps/unix/sysv/linux/arc/Implies | 2 -- > sysdeps/unix/sysv/linux/csky/Implies | 2 -- > sysdeps/unix/sysv/linux/generic/README | 11 ----------- > sysdeps/unix/sysv/linux/loongarch/lp64/Implies | 1 - > sysdeps/unix/sysv/linux/nios2/Implies | 2 -- > sysdeps/unix/sysv/linux/or1k/Implies | 2 -- > sysdeps/unix/sysv/linux/riscv/rv32/Implies | 2 -- > sysdeps/unix/sysv/linux/riscv/rv64/Implies | 1 - > 9 files changed, 24 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/generic/README > > diff --git a/sysdeps/unix/sysv/linux/aarch64/Implies b/sysdeps/unix/sysv/linux/aarch64/Implies > index 4409e19b92..9c2d2c9870 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/Implies > +++ b/sysdeps/unix/sysv/linux/aarch64/Implies > @@ -1,3 +1,2 @@ > aarch64/nptl > -unix/sysv/linux/generic > unix/sysv/linux/wordsize-64 > diff --git a/sysdeps/unix/sysv/linux/arc/Implies b/sysdeps/unix/sysv/linux/arc/Implies > index 7f739a0340..5c1698c045 100644 > --- a/sysdeps/unix/sysv/linux/arc/Implies > +++ b/sysdeps/unix/sysv/linux/arc/Implies > @@ -1,3 +1 @@ > arc/nptl > -unix/sysv/linux/generic/wordsize-32 > -unix/sysv/linux/generic > diff --git a/sysdeps/unix/sysv/linux/csky/Implies b/sysdeps/unix/sysv/linux/csky/Implies > index f37776ccef..2259772947 100644 > --- a/sysdeps/unix/sysv/linux/csky/Implies > +++ b/sysdeps/unix/sysv/linux/csky/Implies > @@ -1,3 +1 @@ > -unix/sysv/linux/generic/wordsize-32 > -unix/sysv/linux/generic > csky/nptl > diff --git a/sysdeps/unix/sysv/linux/generic/README b/sysdeps/unix/sysv/linux/generic/README > deleted file mode 100644 > index 301a6107e1..0000000000 > --- a/sysdeps/unix/sysv/linux/generic/README > +++ /dev/null > @@ -1,11 +0,0 @@ > -This hierarchy supports Linux systems using the new > -asm-generic/unistd.h, which removes many familiar old syscalls. For > -example, to implement open(), newer Linux architectures require glibc > -to invoke the __NR_openat syscall with AT_FDCWD. This hierarchy > -provides all those implementations. > - > -It also provides support for 32-bit platforms using the 64-bit kernel > -syscall APIs, as the 32-bit ones are no longer provided. Note that > -newer ILP32 environments (x32 or AArch64:ILP32, for example) are > -converting to use more 64-bit types in kernel syscalls, so that aspect > -of this support is in more flux as of this writing. > diff --git a/sysdeps/unix/sysv/linux/loongarch/lp64/Implies b/sysdeps/unix/sysv/linux/loongarch/lp64/Implies > index 117c2b8efe..e0390cc3bf 100644 > --- a/sysdeps/unix/sysv/linux/loongarch/lp64/Implies > +++ b/sysdeps/unix/sysv/linux/loongarch/lp64/Implies > @@ -1,3 +1,2 @@ > unix/sysv/linux/loongarch > -unix/sysv/linux/generic > unix/sysv/linux/wordsize-64 > diff --git a/sysdeps/unix/sysv/linux/nios2/Implies b/sysdeps/unix/sysv/linux/nios2/Implies > index 4d0478bf8f..e6c9be4665 100644 > --- a/sysdeps/unix/sysv/linux/nios2/Implies > +++ b/sysdeps/unix/sysv/linux/nios2/Implies > @@ -1,3 +1 @@ > nios2/nptl > -unix/sysv/linux/generic/wordsize-32 > -unix/sysv/linux/generic > diff --git a/sysdeps/unix/sysv/linux/or1k/Implies b/sysdeps/unix/sysv/linux/or1k/Implies > index f39f16c04a..07f8e71adc 100644 > --- a/sysdeps/unix/sysv/linux/or1k/Implies > +++ b/sysdeps/unix/sysv/linux/or1k/Implies > @@ -1,3 +1 @@ > or1k/nptl > -unix/sysv/linux/generic/wordsize-32 > -unix/sysv/linux/generic > diff --git a/sysdeps/unix/sysv/linux/riscv/rv32/Implies b/sysdeps/unix/sysv/linux/riscv/rv32/Implies > index 8b7deb33cd..83db34c5d5 100644 > --- a/sysdeps/unix/sysv/linux/riscv/rv32/Implies > +++ b/sysdeps/unix/sysv/linux/riscv/rv32/Implies > @@ -1,3 +1 @@ > unix/sysv/linux/riscv > -unix/sysv/linux/generic/wordsize-32 > -unix/sysv/linux/generic > diff --git a/sysdeps/unix/sysv/linux/riscv/rv64/Implies b/sysdeps/unix/sysv/linux/riscv/rv64/Implies > index f042343bf7..2f9ad9ff94 100644 > --- a/sysdeps/unix/sysv/linux/riscv/rv64/Implies > +++ b/sysdeps/unix/sysv/linux/riscv/rv64/Implies > @@ -1,3 +1,2 @@ > unix/sysv/linux/riscv > -unix/sysv/linux/generic > unix/sysv/linux/wordsize-64 -- Cheers, Carlos.