unofficial mirror of libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Amrita H S <amritahs@linux.vnet.ibm.com>
To: Paul E Murphy <murphyp@linux.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH V2] powerpc: Optimized strncmp for power10
Date: Mon, 29 Apr 2024 15:30:26 +0530	[thread overview]
Message-ID: <1dd44a65-364f-464b-91d6-9b9930cae179@linux.vnet.ibm.com> (raw)
In-Reply-To: <0e78bb99-c506-412d-898b-c2b9c10c7409@linux.ibm.com>

Hi Paul,

Thanks for reviewing the patch.

On 25/04/24 10:19 pm, Paul E Murphy wrote:
> 
> 
> On 12/18/23 9:28 AM, Amrita H S wrote:
>> +#define TAIL_FIRST_16B(vreg1,vreg2) \
>> +    vctzlsbb r6,v7;             \
>> +    cmpld     cr7,r5,r6;         \
>> +    ble     cr7,L(ret0);       \
>> +    vextubrx r5,r6,vreg1;       \
>> +    vextubrx r4,r6,vreg2;       \
>> +    subf     r3,r4,r5;          \
>> +    blr;
>> +
>> +#define TAIL_SECOND_16B(vreg1,vreg2) \
>> +    vctzlsbb r6,v7;              \
>> +    addi     r0,r6,16;           \
>> +    cmplw     cr7,r5,r0;          \
> 
> Should this be cmpld?
Done.
> 
>> +    ble     cr7,L(ret0);        \
>> +    vextubrx r5,r6,vreg1;        \
>> +    vextubrx r4,r6,vreg2;        \
>> +    subf     r3,r4,r5;           \
>> +    blr;
> 
> Otherwise, LGTM.

Submitted V3 version of the patch.


      reply	other threads:[~2024-04-29 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 15:28 [PATCH V2] powerpc: Optimized strncmp for power10 Amrita H S
2024-04-25 16:49 ` Paul E Murphy
2024-04-29 10:00   ` Amrita H S [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/libc/involved.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1dd44a65-364f-464b-91d6-9b9930cae179@linux.vnet.ibm.com \
    --to=amritahs@linux.vnet.ibm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=murphyp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).