From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 1DAD61F5AE for ; Fri, 24 Jul 2020 20:40:12 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20DD23857027; Fri, 24 Jul 2020 20:40:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 20DD23857027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1595623211; bh=8/6lDyFP0IzuptWNH1tG83j5XY5WnYxEIyFlXrxhYA8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=pSJpqgTacW5eK9c3wAlbMkKc+ag6AljxzovXvCcFprDUWW5b/0aaEcLHHEbzqAz0K 2rLO75sPVI6XCgmKcsW++T7M63RHnj5a7tF4c4gei0iiidIzCXCwR+1T9jN/SfoV/Z rU6k0uc2UUY1EpMekvX0T+/5gldPVhkci1Jo5WGQ= Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id E531A3857027 for ; Fri, 24 Jul 2020 20:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E531A3857027 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-m_okASiFPFmfnv4kUEAYfA-1; Fri, 24 Jul 2020 16:40:06 -0400 X-MC-Unique: m_okASiFPFmfnv4kUEAYfA-1 Received: by mail-qk1-f199.google.com with SMTP id k142so7102052qke.7 for ; Fri, 24 Jul 2020 13:40:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8/6lDyFP0IzuptWNH1tG83j5XY5WnYxEIyFlXrxhYA8=; b=ICi0WXb5zuqYKcaTVEWS4JPUVCcqbI7CIjY5TvN/h0bs9g0HXT5UXfOmat6mg69cEO /scLInJjZD5F6thNeZznFjqjuSq22NWD8uHfBqooWuv490Ab+WVAPnClUC7tx8GY+Cal ExqIml0GEH7JRncScXJiAmizRa+YrZvTSmtw5p/CDevV31fmWf0h3neq2Be9eIUdPXm6 4bYddKmZSnYPuq5PgWsC2sbmE23yq4s6rK552kE5s8+ar8xShpCHJsVvQl9kc7xDjLZM kUCW10P21d6gsBFq0rzh66qQjbxsIRNmCIuHy/gLmuogBBznEFpt5MHt8595GqouVY3/ 7dow== X-Gm-Message-State: AOAM531DPBIsV0Rk5cwAbqc7aLP4zKfAELY6Hf5+GDmeue41En7h6tJB tSGGY8uCC2j7j3j0qKvAViaQfNRfADJD4wwdnsxGDLVgyCRQiXxEUlO2VyhdHWwKemK0aTu178T t78HO6Gj9DlDu788xFia/ X-Received: by 2002:a05:620a:565:: with SMTP id p5mr13051097qkp.215.1595623206163; Fri, 24 Jul 2020 13:40:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGlSvLHi0ZBbI4jXxgxfpjZe1P7VOuuAKqrHdT4JCk0qQXX8LeHy4FnMa8FzDJMNpEJzfK4w== X-Received: by 2002:a05:620a:565:: with SMTP id p5mr13051084qkp.215.1595623205958; Fri, 24 Jul 2020 13:40:05 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id a3sm7330117qkf.131.2020.07.24.13.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2020 13:40:05 -0700 (PDT) Subject: Re: [PATCH] NEWS: Deprecate weak libpthread symbols for single-threaded checks To: Florian Weimer , libc-alpha@sourceware.org References: <875zad7yrc.fsf@oldenburg2.str.redhat.com> Organization: Red Hat Message-ID: <1bc15e73-3d9f-8f63-eccc-952ed8bab27b@redhat.com> Date: Fri, 24 Jul 2020 16:40:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <875zad7yrc.fsf@oldenburg2.str.redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 7/24/20 10:50 AM, Florian Weimer via Libc-alpha wrote: > Recommend the new __libc_single_thread variable instead. > > --- > NEWS | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/NEWS b/NEWS > index 83aed60e19..7fb167e650 100644 > --- a/NEWS > +++ b/NEWS > @@ -134,6 +134,14 @@ Deprecated and removed features, and other changes affecting compatibility: > or contents might be overwritten on subsequent calls in the same thread or > if the thread is terminated. It makes strerror MT-safe. > > +* Using weak references to libpthread functions such as pthread_create > + or pthread_key_create to detect the singled-threaded nature of a > + program is an obsolescent feature. Future versions of glibc will > + define pthread_create within libc.so.6 itself, so such checks will > + always flag the program as multi-threaded. Applications should check > + the __libc_single_threaded variable declared in > + instead. > + > * The "files" NSS module no longer supports the "key" database (used for > secure RPC). The contents of the /etc/publickey file will be ignored, > regardless of the settings in /etc/nsswitch.conf. (This method of > OK for 2.32. Reviewed-by: Carlos O'Donell -- Cheers, Carlos.