From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 23B2D1F4C1 for ; Wed, 30 Nov 2022 02:11:47 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="tLgDflQD"; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 514743858C1F for ; Wed, 30 Nov 2022 02:11:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 514743858C1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669774305; bh=JLimxhqjCyLm8uGMCsuk6K9Uoj917Ln5A2QvwUkcQvw=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=tLgDflQD48rK33c1wRlSRu2GRk9+eYF4QqDw9yzOP3XillRhI8/kiaWXyfjSW1n0q tO+Wvmm+YwbqBs9qNJPKG3zavbdJfuaXz4T/nDUujn8fPIZElZ8WUyACnd+PUalZFS MHYUsbt7EYc2/bnFYnfB+twLykpqZGWNvK0iRBdU= Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by sourceware.org (Postfix) with ESMTPS id 7657B3858D28 for ; Wed, 30 Nov 2022 02:11:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7657B3858D28 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CA346194E; Wed, 30 Nov 2022 02:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 341A5C433B5; Wed, 30 Nov 2022 02:11:24 +0000 (UTC) Message-ID: <1a37cede-b77c-3548-9e3c-470127359a4d@linux.dev> Date: Tue, 29 Nov 2022 18:11:23 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 1/2] scripts: Add "|" operator support to glibcpp's parsing Content-Language: en-US To: Florian Weimer , Shahab Vahedi Cc: libc-alpha@sourceware.org, Claudiu Zissulescu , arcml References: <20221118131542.23188-1-shahab@synopsys.com> <20221127173825.3106-1-shahab@synopsys.com> <20221127173825.3106-2-shahab@synopsys.com> <87h6yk1cn6.fsf@oldenburg.str.redhat.com> In-Reply-To: <87h6yk1cn6.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vineet Gupta via Libc-alpha Reply-To: Vineet Gupta Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 11/27/22 10:21, Florian Weimer via Libc-alpha wrote: > * Shahab Vahedi: > >> From the tests point of view, this is a necessary step for another >> patch [1] and allows parsing macros such as "#define A | B". Without >> it, a few tests [2] choke when the other patch [1] is applied: >> >> /src/glibc/scripts/../elf/elf.h:4167: error: uninterpretable macro >> token sequence: ( EF_ARC_MACH_MSK | EF_ARC_OSABI_MSK ) >> Traceback (most recent call last): >> File "/src/glibc/elf/tst-glibcelf.py", line 23, in >> import glibcelf >> File "/src/glibc/scripts/glibcelf.py", line 226, in >> _elf_h = _parse_elf_h() >> ^^^^^^^^^^^^^^ >> File "/src/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h >> raise IOError('parse error in elf.h') >> OSError: parse error in elf.h >> >> [1] ARC: update definitions in elf/elf.h >> https://sourceware.org/pipermail/libc-alpha/2022-November/143503.html >> >> [2] >> tst-glibcelf, tst-relro-ldso, and tst-relro-libc >> >> Signed-off-by: Shahab Vahedi > > This okay and can go in separately, thanks. > > Reviewed-by: Florian Weimer Committed ! Thx, -Vineet