From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A908B1F453 for ; Thu, 17 Jan 2019 18:55:34 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=vtmbruTQ2xFrVytL poCqpefoTDpMHIJW1hSFMRZiH2kEDPFYH3awxCJ1SMn0/Xw8cM8GVn+3rv/lhCwd 1OQvePT0vbTjWnXAxWi0UaOWjY5wecRAHV6IGKL2/mFZlA2UwvIBRD5KvXIOWzwT hT1iOH+ddeE6fF17Old+t0iWO34= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=iD7QOXzUOEOu35CREEN7eT e9llo=; b=JgBG/hdgQe7jBSqXLkaoaw6QTILC3CahIMLeHEtKea5ca2hMq17swC sIcAMMxuDV5p71yR0I//rc7MBKEUOUOKW4btUIaLCyiqSnVR2uf/yrDu2to3JG82 s5rxYaZPYXURQ2E8kZFeNwBO3C/Fz06S5vLRNPC14cYYv6wYNMsKI= Received: (qmail 11571 invoked by alias); 17 Jan 2019 18:55:32 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 11552 invoked by uid 89); 17 Jan 2019 18:55:31 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: shared-ano163.rev.nazwa.pl Date: Thu, 17 Jan 2019 19:54:09 +0100 (CET) From: Rafal Luzynski To: Zack Weinberg , TAMUKI Shoichi Cc: GNU C Library Message-ID: <184032555.404911.1547751249485@poczta.nazwa.pl> In-Reply-To: References: <201901110447.AA04173@tamuki.linet.gr.jp> <201901110452.AA04175@tamuki.linet.gr.jp> Subject: Re: [PATCH v6 2/2] strftime: Pass the additional flags from "%EY" to "%Ey" [BZ #23758] MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit 16.01.2019 17:17 Zack Weinberg wrote: > > This review covers only the documentation and commit message. Thank you Zack and Paul for your reviews. They were the most missing part. I believe we will help ourselves with the rest of the patches. > [...] > (It seems to me that this extension ought to be generalized to all of > the "macro" formats (%c, %D, %F, %r, %R, %T, %x, %X, %Ec, %Ex, %EX), > and to all format flags and field widths, but that would be a separate > patch and not appropriate for 2.29 at this point.) This may be too ambiguous and therefore impossible to implement. > [...] > Paul's suggested revision of this addition is technically incorrect; > he got confused about which way around the flag propagates. I would > recommend using a separate bullet point for this change, and I would > also recommend not describing the behavior in terms of implementation > details: > > | * As a GNU extension, the '-' and '_' flags can now be applied to '%EY' > | to control how the year number is formatted; they have the same effect > | that they would on %Ey. "they would" or "they would have"? Also, shouldn't all format specifiers be consequently quoted, like "%EY" and "%Ey"? I don't mind single quotes, especially for the flags, I just think that %Ey (without any quotes) may not be absolutely clear. Regards, Rafal