From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id E46F51F66E for ; Mon, 17 Aug 2020 13:58:13 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 27C3E3851C2B; Mon, 17 Aug 2020 13:58:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 27C3E3851C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1597672693; bh=jdV0Fgum0Kz/N+feCUhsRpq07c39u+m4A1XWUpDqvMs=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EVJipx5+478bTIIMrOURl8/501lRVfpd0kul/jHZVUwSqAyeqa4ZlYCeCZU1+kggZ EdPAxK9eyInvvuXw8zVYW5b1Wbcobc4X/+KWXmLJD1zxBott+JrDRGc6J0j3GP9Tpt fKWEZAmd4P1JZHlvVuHdVyKSN1B8Vz6A09RmxWh4= Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id 7400F3857C47 for ; Mon, 17 Aug 2020 13:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7400F3857C47 Received: by mail-qt1-x844.google.com with SMTP id e5so12403673qth.5 for ; Mon, 17 Aug 2020 06:58:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jdV0Fgum0Kz/N+feCUhsRpq07c39u+m4A1XWUpDqvMs=; b=p307yJeWy2tY/z0wKRzoVw9sW4HjW1awcwcewitxn/T08FAeHuTtDtwGlmqIF8ElB1 7P7a2BAiInj8uQqINi+7M9JKrtk7YOoh2h8iPpdDdbfmE5UgrB6q74zJh48BsLz0Y10h BecoXu6Y+MAHm5oZrnNoE27yKXmY/tEcarBIvU4vPFuEJDj02JgqcB/qGfSjgWD1wkPb ULSXa4delczrlbvgZoLxfqd9Z+YBT16+s+KDnZfVxBb7/FEXFt+ALCN1gq6f4AfUDkho 47uh49a0FCxoXdW1j49irtbHqLy+jQ12od3Gy5xoHPkGYm+7anGKYu6GRhFDnZikS+ic EbMA== X-Gm-Message-State: AOAM531CETAtv+ZBaaQA3XufGxr0rfbv1aRGSmdR9h6jM2P3+lYyrXB8 8xvCQJnxynwfpYtkPOAXNKgJ0A== X-Google-Smtp-Source: ABdhPJx7vvqn2mSF9o10oU9lcuJOrdWgv7BURC+uew/8A9fdmhgQIi1oUWjdoajPVp1hAxVl6uTmWw== X-Received: by 2002:aed:2986:: with SMTP id o6mr13297414qtd.105.1597672689746; Mon, 17 Aug 2020 06:58:09 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id t8sm17816466qke.7.2020.08.17.06.58.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2020 06:58:08 -0700 (PDT) Subject: Re: [PATCH] nptl: Handle NULL abstime [BZ #26394] To: "H.J. Lu" , Lukasz Majewski References: <20200812102205.14816-1-lukma@denx.de> <20200817153019.6d86b10c@jawa> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <17ab2619-7b27-028d-98c3-87056a4ef160@linaro.org> Date: Mon, 17 Aug 2020 10:58:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Florian Weimer , GNU C Library , Andreas Schwab , Stepan Golosunov , Alistair Francis , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 17/08/2020 10:52, H.J. Lu wrote: > On Mon, Aug 17, 2020 at 6:30 AM Lukasz Majewski wrote: >> >> Hi Andreas, H.J., >> >>> On Aug 15 2020, H.J. Lu wrote: >>> >>>> From fa1f97680fca290a378c449f2b63682ee348fd2c Mon Sep 17 00:00:00 >>>> 2001 From: "H.J. Lu" >>>> Date: Sat, 15 Aug 2020 11:06:35 -0700 >>>> Subject: [PATCH] nptl: Handle NULL abstime [BZ #26394] >>>> >>>> Since abstime passed to pthread_{clock|timed}join_np may be NULL, >> >> Could you point me to the exact reference that it is allowed (or >> required) to pass NULL to this syscall? >> >> The one which I've found on the web: >> https://linux.die.net/man/3/pthread_timedjoin_np >> >> doesn't mention about NULL pointer passed as the absolute time. >> It says explicitly: >> "The abstime argument is a structure of the following form, specifying >> an absolute time measured since the Epoch" >> >> >> As fair as I remember [1] glibc only handles the NULL pointer case when >> it is explicitly written in the documentation/spec that NULL is passed >> (like here: https://linux.die.net/man/2/timerfd_settime or here: >> https://linux.die.net/man/2/utimensat). >> >> Link: >> [1] - >> https://sourceware.org/pipermail/libc-alpha/2019-November/108072.html >> > > sysdeps/pthread/tst-join14.c explicitly passes NULL: > > static int > do_test_clock (clockid_t clockid) > { > pthread_t th = xpthread_create (NULL, tf, NULL); > > void *status; > int val = (clockid == CLOCK_USE_TIMEDJOIN) > ? pthread_timedjoin_np (th, &status, NULL) > : pthread_clockjoin_np (th, &status, clockid, NULL); > TEST_COMPARE (val, 0); > > if (status != (void *) 42l) > FAIL_EXIT1 ("return value %p, expected %p\n", status, (void *) 42l); > > return 0; > } > And it is a red-flag that you did not catch it running the testsuite. Did you check the patch with a full make check to certify there is no regressions?