From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-2.4 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 831801F85A for ; Tue, 10 Jul 2018 19:26:57 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=SVslr0duNdPUXNt9 lD4v2+To3u7ST+a9e19tYkDvx0yj+eZjA/SFSePDsCn34il9wkqyez/+HKAvkCKD S8aWzMqAJnnH+8usNXQBQUStU8ZPSGNaie11lFaK7UH8/Dug2mALShdDLQNmVJrG 2SNv0EdPd34173Zr1ygg9HBpCOg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=Bp3eWc5pzCCB++u3LyAV7p +1tYo=; b=Jlrg5XptCffu7LrNXFm2Jfvv94AE6grc95G2Eys6qS0HdYRAMoRIf3 6QqgjyEZjnXORtosbngyt4Zao8HWvAUckX8zlspQXCSWYE08yWUIL7KQx9t+fhyf shymExnikvixaZEC40f3Zp7FAKhzY/etKXwzC/J5ctqaMsmHGuE28= Received: (qmail 74622 invoked by alias); 10 Jul 2018 19:26:54 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 74607 invoked by uid 89); 10 Jul 2018 19:26:54 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-vk0-f66.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MCDRixvn/YQsG88R+Lx7YYQKtR3FpojZA8lBajpfKjU=; b=BlIvICmYfOGmdQKImDEB+/J3RnFU4FzJUMLg4L1NgdZLyRNLp31TsRCQiHR8UXLtiR RCuU8w3XRD/kqOHpOfD8tXSSbfvl28HIiYfdz729NFkeO9PXxC8R8UsTDZyAFlG/9IPF P7+jkmXI3HFW995WB+yTgiFLS1AabmmE/ZPsM= Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Florian Weimer , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> Date: Tue, 10 Jul 2018 16:26:46 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 06/07/2018 09:46, Florian Weimer wrote: > On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ >>                 pthread_mutex_getprioceiling \ >>                 pthread_mutex_setprioceiling \ >>                 pthread_setname pthread_getname \ >> -              pthread_setattr_default_np pthread_getattr_default_np >> +              pthread_setattr_default_np pthread_getattr_default_np \ >> +              thrd_create thrd_current thrd_detach thrd_equal \ > > thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. > > Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and thrd_yield) to libc on my personal branch [1] (the change is just to move the objects from libpthread-routines to routines rule in nptl/Makefile). I also adjusted the abilist patch with the change. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/c11-threads