From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id F40761F45D for ; Mon, 23 Mar 2020 17:04:05 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E5E4385E002; Mon, 23 Mar 2020 17:04:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E5E4385E002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1584983044; bh=FEBWKyskA+pNs2amPV6olYxT35PEd5mj6VIAp5sl6ys=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=bVNPiPJpA/jwH0lwyapI1Rs4VP67dzFLeib3bnRekRZbpc5uAHMoOWaBXbXREYRt1 fEcXbG7hcx3iJ1881G0VEESPScdfPNkin0OcGNONwfAv0GhI/Q+bc0KGiXz6eI30r9 4VhNzYpTOT5yOQxgf6PVlNIKOH6PPJa9nvzRAdOw= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id C9ABB385B834 for ; Mon, 23 Mar 2020 17:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C9ABB385B834 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 8541924987C; Mon, 23 Mar 2020 13:04:01 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id e_a1yS7oriLv; Mon, 23 Mar 2020 13:04:01 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 45A78249C0E; Mon, 23 Mar 2020 13:04:01 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 45A78249C0E X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0buCrL8g79V5; Mon, 23 Mar 2020 13:04:01 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 3C5EB249C0D; Mon, 23 Mar 2020 13:04:01 -0400 (EDT) Date: Mon, 23 Mar 2020 13:04:01 -0400 (EDT) To: "H.J. Lu" , Florian Weimer Message-ID: <1758070340.7653.1584983041213.JavaMail.zimbra@efficios.com> In-Reply-To: References: <20200323131607.15185-1-mathieu.desnoyers@efficios.com> <20200323131607.15185-2-mathieu.desnoyers@efficios.com> Subject: Re: [RFC PATCH glibc 1/8] Introduce MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3918 (ZimbraWebClient - FF74 (Linux)/8.8.15_GA_3895) Thread-Topic: Introduce Thread-Index: fG9z6vAxKph3Q3ULYya+GJTRcOtMbA== X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mathieu Desnoyers via Libc-alpha Reply-To: Mathieu Desnoyers Cc: libc-alpha , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" ----- On Mar 23, 2020, at 10:51 AM, H.J. Lu hjl.tools@gmail.com wrote: > On Mon, Mar 23, 2020 at 6:18 AM Mathieu Desnoyers via Libc-alpha > wrote: >> >> From: Florian Weimer >> >> MIPS needs to ignore certain existing symbols during symbol lookup. >> The old scheme uses the ELF_MACHINE_SYM_NO_MATCH macro, with an >> inline function, within its own header, with a sysdeps override for >> MIPS. This allows re-use of the function from another file (without >> having to include or providing the default definition >> for ELF_MACHINE_SYM_NO_MATCH). >> >> Built with build-many-glibcs.py, with manual verification that >> sysdeps/mips/elf_machine_sym_no_match.h is picked up on MIPS. Tested >> on aarch64-linux-gnu, i686-linux-gnu, powerpc64-linux-gnu, >> s390x-linux-gnu, x86_64-linux-gnu. >> >> * elf/elf_machine_sym_no_match.h: New file. >> * elf/dl-lookip.c (ELF_MACHINE_SYM_NO_MATCH): Do not define. >> * elf/dl-lookup.c (check_match) Call elf_machine_sym_no_match >> instead of ELF_MACHINE_SYM_NO_MATCH. >> * sysdeps/mips/dl-machine.h (ELF_MACHINE_SYM_NO_MATCH): Remove >> definition. >> * sysdeps/mips/elf_machine_sym_no_match.h: New file. Extracted >> from sysdeps/mips/dl-machine.h. > > Why not sysdeps/generic/elf_machine_sym_no_match.h? It matches > sysdeps/mips/elf_machine_sym_no_match.h better. I'm fine with your proposal, but this patch is authored by Florian. I will let him reply, and then I'll update the patch as needed. Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com