From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id C31631F4B4 for ; Mon, 5 Apr 2021 11:04:37 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F191C3857829; Mon, 5 Apr 2021 11:04:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F191C3857829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1617620677; bh=gv32WaGCZiOYTMYoQFX/+iQcrfdxarDA+s2FE6lktyA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cTEeUjuAHUJ7JpcTvGXl3fKLM9MDYN77Y0UUnFWCrRzX71I81G8rbRx4h4qfaxQjV dVPNvYodd5kfBJjRMfOm0kwagQj5XeNt3V8pGemUxPlAyqAWJhjPcUGmkgp0gq7aQd DfOFWWVkiuKB1qnUAjWmxxhcqn+56LaWNqc4u2Gw= Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 6F7693857C4C for ; Mon, 5 Apr 2021 11:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F7693857C4C Received: by mail-wr1-x430.google.com with SMTP id q26so4912910wrz.9 for ; Mon, 05 Apr 2021 04:04:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gv32WaGCZiOYTMYoQFX/+iQcrfdxarDA+s2FE6lktyA=; b=P8MXVpfzNF1TG0m4OYAq0vylf8h/myTjkMTEn0ExN6CReWdgVLVbkqs1IS6e7m3gsb rJY0tkIQOb5WjVtfL/4JCXe3QZuY5GxP81sB9VF62i3fRDaSlSQtsEQd04nLmsX+hNKe 1jtaIDqf5tM5gkCY3j76wO5ICvHjxM9ufzDuWJhVGtIvJ44r6jRFixENkhFKtqu4FMJh FrWC5dd3xZ/ruHdF0vT5n3rlcYfzjGGJzYPwXYoi1fwjbshfD7cJt81iVNmvIU6CtBTg sQb+WLEQVUSRRYzsMZU49tBqyBuSvDPzpBXEaHZE/0L/RGQztt5S2vIwIRhnPkLdfdIx EiuQ== X-Gm-Message-State: AOAM532/+klnwoC9AZ5kfJdu81hlFm6wkaJVzqvgjaV2wop31Muv1l0p BDw9+31Yd/y7PHrItUUVvfwxPkPrlMQ= X-Google-Smtp-Source: ABdhPJzcLw6DHVDeGGg5HpILCDfmwq9aZJXCjpMjBPSn0tMhd7B96yommxFsBI7SNe9v8QtXTdHa/w== X-Received: by 2002:a5d:550b:: with SMTP id b11mr29069804wrv.313.1617620671411; Mon, 05 Apr 2021 04:04:31 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id y12sm2210095wrs.65.2021.04.05.04.04.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:04:30 -0700 (PDT) Subject: Re: [PATCH v5 34/35] ioctl_fslabel.2: Make clear why exactly is each header needed To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-35-alx.manpages@gmail.com> Message-ID: <1753f8e6-28f7-b64e-a869-8b4b4c03d815@gmail.com> Date: Mon, 5 Apr 2021 13:04:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-35-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Michael Kerrisk \(man-pages\) via Libc-alpha" Reply-To: "Michael Kerrisk \(man-pages\)" Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org, mtk.manpages@gmail.com Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > Only the include that provides the prototype doesn't need a comment. > > Also sort the includes alphabetically. > > Signed-off-by: Alejandro Colomar Patch applied. Thanks, Michael > --- > man2/ioctl_fslabel.2 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/man2/ioctl_fslabel.2 b/man2/ioctl_fslabel.2 > index af17256f0..30435e1e9 100644 > --- a/man2/ioctl_fslabel.2 > +++ b/man2/ioctl_fslabel.2 > @@ -25,8 +25,8 @@ > ioctl_fslabel \- get or set a filesystem label > .SH SYNOPSIS > .nf > +.BR "#include " " /* Definition of " *FSLABEL* " constants */" > .B #include > -.B #include > .PP > .BI "int ioctl(int " fd ", FS_IOC_GETFSLABEL, char " label [FSLABEL_MAX]); > .BI "int ioctl(int " fd ", FS_IOC_SETFSLABEL, char " label [FSLABEL_MAX]); > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/