From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on starla X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id AE95C1F44D for ; Fri, 22 Mar 2024 14:14:41 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=Qx5tfegv; dkim-atps=neutral Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C3823858C35 for ; Fri, 22 Mar 2024 14:14:40 +0000 (GMT) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 09873385828B for ; Fri, 22 Mar 2024 14:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09873385828B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09873385828B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711116860; cv=none; b=WBLU3Bt6VQ1E4HClNL5yzxG+yFeP/ZboSxvnlCG2VrKYgfFIx7zzaxIBinBnbIp1Fty4/1n9KYHviJbtUsaVwZYsryvTv8FGTLuvSU8XpRwY20SjYeQlcl/SSSac1nGO4cvcbbf4bzO82wh5eRQxfw9PG5R3pjmYSzpo6fGNhGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711116860; c=relaxed/simple; bh=8zC2rtSUZJSwb5jNjP/IQ+eJ8kSIAOkw9J3e/fGSWOY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aG8pjnuzlfRHvB72fBSm0C9nS0xn2r/CaZv+T537ENAMRaYXpcxY/1JFH0hRlbx0zs9j/bGJUo/rbE9GLxDou5IGhUg46T2UUx3OttxuYGEz09gJVs4RZYGuIYkNrdPn9ba5OVKqDJzUjHk5MQyVq17pkABx9I87+gqUyf9/Dv4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1e07cd7b798so12063045ad.2 for ; Fri, 22 Mar 2024 07:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711116855; x=1711721655; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=XBWzbkQRDeEeZoOF7CPZOe14MMerKXguskAQDCNOw3M=; b=Qx5tfegvRGkSVvr+guRghL3gVZVhR152EVySD8u4zjtbmoPIjpnObSlqzS7ZnnjIuY WcBN2wCobS+KX6vlgWiJPwpjbHH9Vr9kxh1n/vLX1CfG0DBQU1CahZAi7lOSaVTiQTs0 GFyZjC9HQrwx8fdKzZvpCuC7wgrDxqNg+CfZX57nBdH+saJfo44RdFXDhCGnPmhEZ6Ka IO+VV5SvQowI/3sqdaxo+L/9tWgRkdcpawtTIRv29GgjPW4sJ4fM9O8IZ+pU3UbiZY88 sj+hQ7exl6HTjVb+NLsNpYAoJkB1mdkhWiOrvxnNdM3exxAaNk5mFhAzOgNKleKYfXYB 3hww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711116855; x=1711721655; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XBWzbkQRDeEeZoOF7CPZOe14MMerKXguskAQDCNOw3M=; b=OIhh5w84tBPZLkr8ZEVTCIix0LKNg4AlpHwJki0r6/TZnmDcZ0T9E0e3QhzOX9YOJD pIUq9mu5RmV5pGKc0Y3BtlD65X8Grxb6BDgzYdoYCvMltqB18vVb2fwZEleb0fpj4kxW mEwPFx7XvnkdIUqHJA+sFCQxkZu+qUik5z8M2+4gjFSsj5pDe9orEQAwaCKfkoghML9j Ugen2JRiG00xSEo26VzpUgGRthVWNu7Fc7jfWZB3yv06q6KWNrcU923eQaLK913+DP3v 1em5qj05QCTafWcTySM+t/51Lo/8NN5gqb6SH4bmY1TUveZKK4Zm/4ZjkfmbGmGoYasT tYug== X-Gm-Message-State: AOJu0Yz8jDSek8JtdORstG4xElYwVSkCChG7yLX3HKEsk20I1CTFelC7 jhuSzIzfdD7jv/6ucXJCWQSznuAby/LRhGtU6LIFuvPBCrmNvlLJt1B+LA1o0TA= X-Google-Smtp-Source: AGHT+IGK6RbcdLmKt2qi/91rpxK1m/hwq1N7oJ+nTUKt6Ztks4qTq/l7yJD3O4XD9uBDIBdJW90OLA== X-Received: by 2002:a17:903:22c3:b0:1dd:6f4c:c67 with SMTP id y3-20020a17090322c300b001dd6f4c0c67mr3038247plg.24.1711116855596; Fri, 22 Mar 2024 07:14:15 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:1d04:bcc1:505d:b612:f9f0? ([2804:1b3:a7c3:1d04:bcc1:505d:b612:f9f0]) by smtp.gmail.com with ESMTPSA id s14-20020a170902ea0e00b001d8aa88f59esm1933181plg.110.2024.03.22.07.14.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Mar 2024 07:14:15 -0700 (PDT) Message-ID: <152e5240-b315-401a-8bdd-03b4be0fe35f@linaro.org> Date: Fri, 22 Mar 2024 11:14:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] math: Add support for auto static math tests Content-Language: en-US To: Florian Weimer , Joseph Myers Cc: libc-alpha@sourceware.org, "H . J . Lu" References: <20240321164325.539976-1-adhemerval.zanella@linaro.org> <20240321164325.539976-2-adhemerval.zanella@linaro.org> <23abf336-5490-d62d-c664-98724630bad0@redhat.com> <87v85edar3.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87v85edar3.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org On 22/03/24 03:46, Florian Weimer wrote: > * Joseph Myers: > >> On Thu, 21 Mar 2024, Adhemerval Zanella wrote: >> >>> It basically copy the already in place rules for dynamic tests >>> for auto-generated math tests for all support types. To avoid >>> the need to duplicate .inc files, a .SECONDEXPANSION rules is >>> adeed for the gen-libm-test.py generation. >> >> Running the autogenerated tests seems overly complicated when the goal is >> simply to verify that linking a call succeeds. > > Right. And I would prefer if we could mark compat/otherwise non-static > symbols in the ABI lists and use those for testing static linking. > That was my first approach, but then as an experiment I enabled static build for most of math tests and unexpectedly it has shows some failures on x86_64: FAIL: math/test-float64x-acos FAIL: math/test-float64x-log10 FAIL: math/test-float64x-log2 FAIL: math/test-float64x-y0 FAIL: math/test-float64x-y1 FAIL: math/test-ldouble-acos FAIL: math/test-ldouble-log10 FAIL: math/test-ldouble-log2 FAIL: math/test-ldouble-y0 FAIL: math/test-ldouble-y1 $ cat math/test-float64x-acos.out testing _Float64x (without inline functions) Failure: acos (max_value): Exception "Overflow" set Failure: acos (-max_value): Exception "Overflow" set Failure: acos_downward (max_value): Exception "Overflow" set Failure: acos_downward (-max_value): Exception "Overflow" set Failure: acos_towardzero (max_value): Exception "Overflow" set Failure: acos_towardzero (-max_value): Exception "Overflow" set Failure: acos_upward (max_value): Exception "Overflow" set Failure: acos_upward (-max_value): Exception "Overflow" set My plan was to eventually track down what might be happening here, and the currently autogenerated tests gave me a nice scaffolding to add coverage tests. I can add simple linking tests for this specific failure, and I also think that reword all the static ABI check for this issues in a bit too much for this patchset.