From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Adhemerval Zanella Newsgroups: gmane.comp.lib.glibc.alpha Subject: [PATCH v2 14/21] nptl: microblaze: Fix Race conditions in pthread cancellation (BZ#12683) Date: Mon, 26 Feb 2018 18:03:29 -0300 Message-ID: <1519679016-12241-15-git-send-email-adhemerval.zanella@linaro.org> References: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1519679065 19317 195.159.176.226 (26 Feb 2018 21:04:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 21:04:25 +0000 (UTC) To: libc-alpha@sourceware.org Original-X-From: libc-alpha-return-90631-glibc-alpha=m.gmane.org@sourceware.org Mon Feb 26 22:04:21 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=lsS4gdL4qGZwq47YOu30AW/opymNgUU rJ1zkNyyjVh82cIuxM7fXpzWzS9fW/n0Wncmj/gllr+JUqnsCXC8WZDpVT7JQ3pq 1FI1ro/ZvVCE5baA9XEoftiroLwXAV6jttc+QkbXvEz7kP+4H2+EmpsZnqR07Qtu 5BJSxNYclqQI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=Lv8Jdvyada9qpoIDj3IK4krzAuM=; b=cPJPZ DqVthz8dig7D1cDG0FwM4/4ChG4eYO0+TYDoLIUbnnVtuPk8Iu/LFxyjDOKexgAa vvXuaXCG3FB6aA/hNzhT4E/zL5hgFp0VliBojDfDNCKeduu/sHAMljN3E9s5IgZs 9BM02mdi1MuSC+4eZzi+/QcwdbyEkfn3JPfRAM= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f195.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=36vmF1UBuyft13pJd4buutC6GdHaCmVgbHI0pKWKCaQ=; b=ffbtHxhRi/SaFiLa7+SHFc6obO5a7bk8h3L6kDVEWMeTXI7yNPNhiTkas+yPyAIGRQ dWSdDuKrXMtRYYRp9i12XC3DpkFr8IuuBqkPL6PC0S/xLz9M0FS/n0G144sQaojVsbri 1ai6jGpush6w+SSItDPNa3N+RTtpVVZ9rpwgfVTYR4RholuEARj8LgnyAd7NZjqK8MF6 QxAsYuz3d/oLzz95h5Dra4/aQUDSl3EY3v1L8MJEXku4xbKauuVUs75XJwr+Zue5hVi+ DVB9sA6Ot1AD7AeKADd58eqnCDc01dWuRoz2Oh/LjPBVUCA1LD0hlPaXUj7rB6ER/RcG m17A== X-Gm-Message-State: APf1xPBcH1DRTSlzW1dZxqXjd89sDVwxKCOivzvMeBQilwYbLvrB4vD0 H44PrwV2E5mnKkSXWUMD0jsYKvDAQJM= X-Google-Smtp-Source: AG47ELspFiznzFChmm8D+MVaIAbapZyIXBFkNLqgRDYsbKxZVoipF3oRp7d1hbmjzQGqMPREyUWh3Q== X-Received: by 10.200.55.233 with SMTP id e38mr19680884qtc.158.1519679045644; Mon, 26 Feb 2018 13:04:05 -0800 (PST) In-Reply-To: <1519679016-12241-1-git-send-email-adhemerval.zanella@linaro.org> Xref: news.gmane.org gmane.comp.lib.glibc.alpha:82963 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqPwZ-0004ls-Rt for glibc-alpha@blaine.gmane.org; Mon, 26 Feb 2018 22:04:20 +0100 Received: (qmail 78410 invoked by alias); 26 Feb 2018 21:04:19 -0000 Received: (qmail 77192 invoked by uid 89); 26 Feb 2018 21:04:09 -0000 This patch adds the microblaze modifications required for the BZ#12683. It basically adds the required ucontext_get_pc function. Microblaze requires an arch specific assembly implementation because the archicture INTERNAL_SYSCALL_NCS implementation adds a nop after the brki instruction because the instruction expect a delay branch slot. I based this implementation on generated assembly using GCC 6.1. Checked against a build and make check run-built-tests=no for microblaze-linux-gnu. [BZ #12683] * sysdeps/unix/sysv/linux/microblaze/syscall_cancel.S: New file. * sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h (ucontext_get_pc): New function. --- ChangeLog | 5 ++ .../unix/sysv/linux/microblaze/sigcontextinfo.h | 13 +++++ .../unix/sysv/linux/microblaze/syscall_cancel.S | 62 ++++++++++++++++++++++ 3 files changed, 80 insertions(+) create mode 100644 sysdeps/unix/sysv/linux/microblaze/syscall_cancel.S diff --git a/sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h b/sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h index 64d8f2f..fae7144 100644 --- a/sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h +++ b/sysdeps/unix/sysv/linux/microblaze/sigcontextinfo.h @@ -16,6 +16,11 @@ License along with the GNU C Library; if not, see . */ +#ifndef _SIGCONTEXTINFO_H +#define _SIGCONTEXTINFO_H + +#include + #define SIGCONTEXT int _code, ucontext_t * #define SIGCONTEXT_EXTRA_ARGS _code, #define GET_PC(ctx) ((void *) (ctx)->uc_mcontext.regs.pc) @@ -23,3 +28,11 @@ #define GET_STACK(ctx) ((void *) (ctx)->uc_mcontext.regs.sp) #define CALL_SIGHANDLER(handler, signo, ctx) \ (handler)((signo), SIGCONTEXT_EXTRA_ARGS (ctx)) + +static inline uintptr_t +ucontext_get_pc (const ucontext_t *uc) +{ + return uc->uc_mcontext.regs.pc; +} + +#endif /* _SIGCONTEXTINFO_H */ diff --git a/sysdeps/unix/sysv/linux/microblaze/syscall_cancel.S b/sysdeps/unix/sysv/linux/microblaze/syscall_cancel.S new file mode 100644 index 0000000..d892362 --- /dev/null +++ b/sysdeps/unix/sysv/linux/microblaze/syscall_cancel.S @@ -0,0 +1,62 @@ +/* Cancellable syscall wrapper. Linux/microblaze version. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include + +/* long int __syscall_cancel_arch (int *cancelhandling, + long int nr, + long int arg1, + long int arg2, + long int arg3, + long int arg4, + long int arg5, + long int arg6) */ + +ENTRY (__syscall_cancel_arch) + + .globl __syscall_cancel_arch_start +__syscall_cancel_arch_start: + + lwi r3,r5,0 + andi r3,r3,4 #and1 + bneid r3,1f + addk r12,r6,r0 + + addk r5,r7,r0 + addk r6,r8,r0 + addk r7,r9,r0 + addk r8,r10,r0 + lwi r9,r1,56 + lwi r10,r1,60 + brki r14,8 + + .globl __syscall_cancel_arch_end +__syscall_cancel_arch_end: + + nop + lwi r15,r1,0 + rtsd r15,8 + addik r1,r1,28 + +1: + brlid r15, __syscall_do_cancel + nop + +END (__syscall_cancel_arch) +libc_hidden_def (__syscall_cancel_arch) + -- 2.7.4