From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Adhemerval Zanella Newsgroups: gmane.comp.lib.glibc.alpha Subject: [PATCH v8 3/8] nptl: Add C11 threads call_once functions Date: Fri, 2 Feb 2018 15:04:39 -0200 Message-ID: <1517591084-11347-4-git-send-email-adhemerval.zanella@linaro.org> References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517591002 29364 195.159.176.226 (2 Feb 2018 17:03:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Feb 2018 17:03:22 +0000 (UTC) To: libc-alpha@sourceware.org Original-X-From: libc-alpha-return-89921-glibc-alpha=m.gmane.org@sourceware.org Fri Feb 02 18:03:17 2018 Return-path: Envelope-to: glibc-alpha@blaine.gmane.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=ciR9gOHnGp51naKVvdo7eocJdeeGB6H Gy8SRDmRVVYM7W3ye6Si56l4etTB6WV3V9Kqa5RmNFYVH0kIc+4YU0Nn9SGaNdsV nM3mRiJ23wRB5IXHM1Lszn2G+2uFBud8B5stl43jSOaC8mhhOKLGNbiI/IjJcE41 YNo8r6WiolKc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=53hpCZqpfjiLsT3xVccw0++DE/4=; b=JSPIM Bj5EP9w3nTZ0/t8dtEQVwOnKzoEjFDCrJkKuWpRPYt2AqYUJms0hhDpyOIWycnE1 EyWDmaiPoHmYuMmmi7H5FXw7eIrHIncHlqJIuoUEfgD8SxsYmjroimhPe6dO72Hz NG2T6JBHzNQWqwQ+5DMlpTSuuJ8OcCHbOvBhFs= Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Original-Sender: libc-alpha-owner@sourceware.org Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f196.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Vadcpi4CPOtyRcqC0+HD4n8hFKjNSlpLc0DvdLda04c=; b=BSl00mPpNHclVIr7c/60LNjrPsgibyDa5zu0l2gv3Hw0/mVveJvErajTK16u2HOdX2 qZz76ktata7ccoi15dcpssyTU18xSpPiGZxH1JyJ1ocGYrDC8r70gu3C8X9SI+PzYbE/ Y/WPSs0jtQGDNfjjUd34n8KXJVMV5Vj0Tq2UoCPD/j2PpaOcZDRitHfz39Rah/58mXAj RLW/Dl48xiP2ithhey4KHE9irG0jxS/YbNKHH8qypDi5ydNh+wUi8y1I/rp4to5bwEHI n0/r9t3uOwFzgBdfNNWNbVByNoSR6fwYat/Utx9Uzt+pUzq+/usDUOLgb3VkJFDhMzmO yZeg== X-Gm-Message-State: AKwxyte3p61RwtFt2U98xvVV9Ux5ptX0UCRgwXMWECOGZ4hQuXKyKPzp RCw052c/K7ED2FK6ZahEbsdOI+ndIkc= X-Google-Smtp-Source: AH8x225ZpKcEGD0gB7zndxMfx1MwUrSZGvrdGsvDpQ1rem6G+BeNhmAmsNYe7jIxj27yXj7y+2ikHw== X-Received: by 10.200.81.83 with SMTP id h19mr10235441qtn.63.1517591096922; Fri, 02 Feb 2018 09:04:56 -0800 (PST) In-Reply-To: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> Xref: news.gmane.org gmane.comp.lib.glibc.alpha:82270 Archived-At: Received: from server1.sourceware.org ([209.132.180.131] helo=sourceware.org) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ehejw-0006c9-P2 for glibc-alpha@blaine.gmane.org; Fri, 02 Feb 2018 18:03:05 +0100 Received: (qmail 129026 invoked by alias); 2 Feb 2018 17:05:02 -0000 Received: (qmail 128885 invoked by uid 89); 2 Feb 2018 17:05:01 -0000 This patch adds the call_* definitions from C11 threads (ISO/IEC 9899:2011), more specifically call_once and required types. Mostly of the definitions are composed based on POSIX conterparts,including once_flag (pthread_once_t). The idea is to make possible to share POSIX internal implementations for mostly of the code (and making adjustment only when required). Checked with a build for all major ABI (aarch64-linux-gnu, alpha-linux-gnu, arm-linux-gnueabi, i386-linux-gnu, ia64-linux-gnu, m68k-linux-gnu, microblaze-linux-gnu [1], mips{64}-linux-gnu, nios2-linux-gnu, powerpc{64le}-linux-gnu, s390{x}-linux-gnu, sparc{64}-linux-gnu, tile{pro,gx}-linux-gnu, and x86_64-linux-gnu). Also ran a full check on aarch64-linux-gnu, x86_64-linux-gnu, i686-linux-gnu, arm-linux-gnueabhf, and powerpc64le-linux-gnu. * conform/data/threads.h-data (ONCE_FLAG_INIT): New macro. (once_flag): New type. (call_once): New function. * nptl/Makefile (libpthread-routines): Add call_once object. * nptl/Versions (libphread) [GLIBC_2.27]: Add call_once symbol. * nptl/call_once.c: New file. * sysdeps/nptl/threads.h (ONCE_FLAG_INIT): New define. (once_flag): New type. (call_once): New prototype. --- ChangeLog | 10 ++++++++++ conform/data/threads.h-data | 5 +++++ nptl/Makefile | 2 +- nptl/Versions | 2 +- nptl/call_once.c | 31 +++++++++++++++++++++++++++++++ sysdeps/nptl/threads.h | 8 ++++++++ 6 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 nptl/call_once.c diff --git a/conform/data/threads.h-data b/conform/data/threads.h-data index bb5ca75..70b2fe0 100644 --- a/conform/data/threads.h-data +++ b/conform/data/threads.h-data @@ -1,5 +1,7 @@ #if defined ISO11 +macro ONCE_FLAG_INIT + constant thrd_success constant thrd_busy constant thrd_error @@ -13,6 +15,7 @@ constant mtx_timed type thrd_t type thrd_start_t type mtx_t +type once_flag function int thrd_create (thrd_t*, thrd_start_t, void*) function int thrd_equal (thrd_t, thrd_t) @@ -30,6 +33,8 @@ function int mtx_trylock (mtx_t*) function int mtx_unlock (mtx_t*) function void mtx_destroy (mtx_t*) +function void call_once (once_flag*, void (*)(void)) + #include "time.h-data" #endif diff --git a/nptl/Makefile b/nptl/Makefile index 1b8a6a8..e539df8 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -143,7 +143,7 @@ libpthread-routines = nptl-init vars events version pt-interp \ thrd_create thrd_current thrd_detach thrd_equal \ thrd_exit thrd_join thrd_sleep thrd_yield \ mtx_destroy mtx_init mtx_lock mtx_timedlock \ - mtx_trylock mtx_unlock + mtx_trylock mtx_unlock call_once # pthread_setuid pthread_seteuid pthread_setreuid \ # pthread_setresuid \ # pthread_setgid pthread_setegid pthread_setregid \ diff --git a/nptl/Versions b/nptl/Versions index a1969e3..f09e295 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -269,7 +269,7 @@ libpthread { GLIBC_2.28 { thrd_create; thrd_current; thrd_detach; thrd_equal; thrd_exit; thrd_join; thrd_sleep; thrd_yield; mtx_init; mtx_lock; mtx_timedlock; mtx_trylock; - mtx_unlock; mtx_destroy; + mtx_unlock; mtx_destroy; call_once; } GLIBC_PRIVATE { diff --git a/nptl/call_once.c b/nptl/call_once.c new file mode 100644 index 0000000..d66d728 --- /dev/null +++ b/nptl/call_once.c @@ -0,0 +1,31 @@ +/* C11 threads call once implementation. + Copyright (C) 2018 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include + +#include "thrd_priv.h" + +void +call_once (once_flag *flag, void (*func)(void)) +{ + _Static_assert (sizeof (once_flag) == sizeof (pthread_once_t), + "once_flag size"); + _Static_assert (alignof (once_flag) == alignof (pthread_once_t), + "once_flag alignment"); + __pthread_once (flag, func); +} diff --git a/sysdeps/nptl/threads.h b/sysdeps/nptl/threads.h index 42d9b5c..6c9c3ef 100644 --- a/sysdeps/nptl/threads.h +++ b/sysdeps/nptl/threads.h @@ -27,8 +27,11 @@ __BEGIN_DECLS #include #include +#define ONCE_FLAG_INIT 0 + typedef unsigned long int thrd_t; typedef int (*thrd_start_t) (void*); +typedef int __ONCE_ALIGNMENT once_flag; /* Exit and error codes. */ enum @@ -129,6 +132,11 @@ extern int mtx_unlock (mtx_t *__mutex); /* Destroy the mutex object pointed by __MUTEX. */ extern void mtx_destroy (mtx_t *__mutex); + +/* Call function __FUNC exactly once, even if invoked from several threads. + All calls must be made with the same __FLAGS object. */ +extern void call_once (once_flag *__flag, void (*__func)(void)); + __END_DECLS #endif /* _THREADS_H */ -- 2.7.4