From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Will Deacon <will.deacon@arm.com>, carlos <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
libc-alpha <libc-alpha@sourceware.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ben Maurer <bmaurer@fb.com>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
Dave Watson <davejwatson@fb.com>, Paul Turner <pjt@google.com>,
Rich Felker <dalias@libc.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>
Subject: Re: [PATCH 1/5] glibc: Perform rseq(2) registration at C startup and thread creation (v8)
Date: Thu, 18 Apr 2019 11:37:14 -0400 (EDT) [thread overview]
Message-ID: <1515751456.1060.1555601834395.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1904181445550.5356@digraph.polyomino.org.uk>
----- On Apr 18, 2019, at 10:48 AM, Joseph Myers joseph@codesourcery.com wrote:
> On Thu, 18 Apr 2019, Mathieu Desnoyers wrote:
>
>> The approach above should work for arm32 be8 vs be32 linker weirdness.
>>
>> For aarch64, I think we can simply do:
>>
>> /*
>> * aarch64 -mbig-endian generates mixed endianness code vs data:
>> * little-endian code and big-endian data. Ensure the RSEQ_SIG signature
>> * matches code endianness.
>> */
>> #define RSEQ_SIG_CODE 0xd428bc00 /* BRK #0x45E0. */
>>
>> #ifdef __ARM_BIG_ENDIAN
>> #define RSEQ_SIG_DATA 0x00bc28d4 /* BRK #0x45E0. */
>> #else
>> #define RSEQ_SIG_DATA RSEQ_SIG_CODE
>> #endif
>>
>> #define RSEQ_SIG RSEQ_SIG_DATA
>>
>> Feedback is most welcome,
>
> You'll also need __ASSEMBLER__ conditionals in the installed sys/rseq.h
> header so that it only defines constants and doesn't include any C
> declarations in that case, if RSEQ_SIG_CODE is meant to be usable in .S
> files rather than just inline asm in C files.
Good point!
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-04-18 15:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 17:32 [PATCH 0/5] Restartable Sequences support for glibc 2.30 Mathieu Desnoyers
2019-04-16 17:32 ` [PATCH 1/5] glibc: Perform rseq(2) registration at C startup and thread creation (v8) Mathieu Desnoyers
2019-04-17 15:59 ` Mathieu Desnoyers
2019-04-17 16:17 ` Joseph Myers
2019-04-17 19:56 ` Mathieu Desnoyers
2019-04-18 13:17 ` Mathieu Desnoyers
2019-04-18 14:48 ` Joseph Myers
2019-04-18 15:37 ` Mathieu Desnoyers [this message]
2019-04-18 15:33 ` Szabolcs Nagy
2019-04-18 15:41 ` Mathieu Desnoyers
2019-04-18 16:07 ` Szabolcs Nagy
2019-04-18 17:10 ` Mathieu Desnoyers
2019-04-18 17:37 ` Szabolcs Nagy
2019-04-18 18:17 ` Mathieu Desnoyers
2019-04-23 11:16 ` Szabolcs Nagy
2019-04-23 11:59 ` Ramana Radhakrishnan
2019-04-23 12:36 ` Mathieu Desnoyers
2019-04-16 17:32 ` [PATCH 2/5] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v2) Mathieu Desnoyers
2019-04-18 15:33 ` Szabolcs Nagy
2019-04-18 15:45 ` Mathieu Desnoyers
2019-04-16 17:32 ` [PATCH 3/5] support record failure: allow use from constructor Mathieu Desnoyers
2019-04-16 17:32 ` [PATCH 4/5] support: implement xpthread key create/delete Mathieu Desnoyers
2019-04-16 17:32 ` [PATCH 5/5] rseq registration tests (v3) Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515751456.1060.1555601834395.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=bmaurer@fb.com \
--cc=boqun.feng@gmail.com \
--cc=carlos@redhat.com \
--cc=dalias@libc.org \
--cc=davejwatson@fb.com \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=szabolcs.nagy@arm.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).