From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 05D6C1F55B for ; Fri, 29 May 2020 13:56:24 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 031FF388C002; Fri, 29 May 2020 13:56:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 031FF388C002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1590760583; bh=ociXOm3U8Fu29DhHGrK+iA+mhbwB74cyxrshQ+0fscs=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Ucp9FiL9qThgRs8ElFBPv9ogujKLyFb/jf1eejs3AJjfCFlibv2/14nJZWfK4qz0t Ce50YQh3dGc4PHQT04+888iexw/gW/kTZSWjjc4woyuZBDhzVt63InbRUTv0zofGCH 5/J7/pgDh/OXr61jQYE07LkfB7ni0YHzeeF6uj7c= Received: from mail-qt1-x842.google.com (mail-qt1-x842.google.com [IPv6:2607:f8b0:4864:20::842]) by sourceware.org (Postfix) with ESMTPS id D5000386F477 for ; Fri, 29 May 2020 13:56:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5000386F477 Received: by mail-qt1-x842.google.com with SMTP id k22so1943642qtm.6 for ; Fri, 29 May 2020 06:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ociXOm3U8Fu29DhHGrK+iA+mhbwB74cyxrshQ+0fscs=; b=ZdsLU2CDSeVruYPCIx/xdgLMYQ1o0CZ6UzzYLUazIV2ZpJxb+chaAcvThu0SJEkt+Y iLH7t2d5sqzu5+EvYY+BkDQqhjtPy0cynk2yh16CzR76Enl+CinhC2naanxXWk7q2Yvc Dvf4uy5UHhi/VpS4a6SeoN/FKF+LsmDq6xxRo7qxOv41bBuGcd4sUyRSFcY4AIY/Nfo/ AMDdrflR6If94RZsLl16+o7gM+J30R6IIDIzhoTmXS/+Rs3Z+S+6WNFZd28zdmHXjynH u5iYLNEQC4nW/FZBYew1ku9ksa9GNBgJJCWXXr4vm2n3LkuybA2E+4pNg/7mtyZDkQcV hBTw== X-Gm-Message-State: AOAM531zb2H+EA0II/ybl95UQfUU2IdAFFQkqP6gqTbVMYO+4cfbprBC CNJPpWI0CXo0bqnHEnLd7c0nag== X-Google-Smtp-Source: ABdhPJxIegJDwWH9hmIVpjfvf8jUm56EzoQ1FMkHFD3sLc1QPMCMEzQ4AB62xuGPVuHXHntea55ZZw== X-Received: by 2002:ac8:1942:: with SMTP id g2mr9117858qtk.107.1590760580382; Fri, 29 May 2020 06:56:20 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id l64sm6886255qkd.15.2020.05.29.06.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2020 06:56:19 -0700 (PDT) To: Vineet Gupta , "libc-alpha@sourceware.org" References: <20200423014126.10417-1-vgupta@synopsys.com> <20200423014126.10417-2-vgupta@synopsys.com> <88508d10-2d29-026a-bb54-ad607154ab87@linaro.org> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH v6 01/13] ARC: ABI Implementation Message-ID: <129265eb-c39a-6394-24ab-8734b04649bb@linaro.org> Date: Fri, 29 May 2020 10:56:17 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: arcml Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 27/05/2020 19:15, Vineet Gupta wrote: > On 5/27/20 11:26 AM, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 22/04/2020 22:41, Vineet Gupta via Libc-alpha wrote: >>> This code deals with the ARC ABI. >>> >>> Signed-off-by: Vineet Gupta >> >> We do not use DCO, but rather copyright assignment. > > Right, removed that now. > >> Looks ok in general, with some comments below. > > Thx for taking a look. > >>> +;@ r1 = value that setjmp( ) will return due to this longjmp >> >> Since all .S files are processed by gcc assembly implementation usually >> use C style comment (/* ... */). Same applies to other assembly >> implementations. > > OK, I can update throughout, although I like the small assembler comments which > are on the same line. I don't have a strong preference and I am not sure if there is a strict code guideline for comment in assembly implementations. It was more a suggestion, since other assembly implementations tend to use C style comment as well. >>> diff --git a/sysdeps/arc/memusage.h b/sysdeps/arc/memusage.h > >>> + >>> +#define GETSP() ({ register uintptr_t stack_ptr asm ("sp"); stack_ptr; }) >>> + >>> +#define uatomic32_t unsigned int >> >> Not sure if this is really required now that we are moving to C11 atomic >> model withing glibc itself. Maybe we could just use uint32_t on >> malloc/memusage.c and rely on atomic macros instead. > > But that would be much bigger change, and orthogonal to the port. So perhaps we > add it for now and then do the bigger/sweeping change. > Indeed, it was more a open note for a future cleanup. The current definition is fine as is.