From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 739381F55B for ; Fri, 5 Jun 2020 17:04:22 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9BCC3389364C; Fri, 5 Jun 2020 17:04:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9BCC3389364C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591376661; bh=klZhEqZl59cE0Iq8mXyYnLHKlmGWX7hKiK1I/qA34oU=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vK/7+be9EPAy4XIilWWUnaTwkxP5etVgG6bzMPHXYNZ3UnYAdFmNrdqHs6nuSeAqE U9Gqo9QO7/rog06A0Z6b8if/BxE8b1Qp172F3Smw0sPVnDHiCrkcZWNHrS2EfP9ZD7 znfcHR2eDD225aDtAH0NFH94ClbymS2HjCyJF5EU= Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id 94FF638930D7 for ; Fri, 5 Jun 2020 17:04:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 94FF638930D7 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 222522CF992; Fri, 5 Jun 2020 13:04:18 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id uZDl77EVK4MC; Fri, 5 Jun 2020 13:04:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id D44C12CF676; Fri, 5 Jun 2020 13:04:17 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com D44C12CF676 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0HZxiG4RlBHi; Fri, 5 Jun 2020 13:04:17 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id CC5FA2CF673; Fri, 5 Jun 2020 13:04:17 -0400 (EDT) Date: Fri, 5 Jun 2020 13:04:17 -0400 (EDT) To: Florian Weimer Message-ID: <1245924698.56744.1591376657757.JavaMail.zimbra@efficios.com> In-Reply-To: <877dwow9lv.fsf@oldenburg2.str.redhat.com> References: <20200527185130.5604-1-mathieu.desnoyers@efficios.com> <878sh4xshf.fsf@oldenburg2.str.redhat.com> <877dwow9lv.fsf@oldenburg2.str.redhat.com> Subject: Re: [PATCH glibc 0/3] Restartable Sequences enablement MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_3928 (ZimbraWebClient - FF76 (Linux)/8.8.15_GA_3928) Thread-Topic: Restartable Sequences enablement Thread-Index: xmJXkKI1iAyBiX/d7HMFKb5W4KaGkw== X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mathieu Desnoyers via Libc-alpha Reply-To: Mathieu Desnoyers Cc: libc-alpha , Joseph Myers Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" ----- On Jun 3, 2020, at 9:40 AM, Florian Weimer fweimer@redhat.com wrote: > * Florian Weimer via Libc-alpha: > >> This series unfortunately needs to be rebased (with conflicts) on >> current master. >> >> There is a new elf/tst-auditmany failure, showing bug 26076, but >> actually caused by bug 26075 (I think). I will attempt to work around >> these two issues, which are independent of the rseq changes. > > Mathieu, it turns out that a change like this is needed: > > diff --git a/elf/dl-tls.c b/elf/dl-tls.c > index fa03234610..817bcbbf59 100644 > --- a/elf/dl-tls.c > +++ b/elf/dl-tls.c > @@ -31,7 +31,7 @@ > > /* Amount of excess space to allocate in the static TLS area > to allow dynamic loading of modules defining IE-model TLS data. */ > -#define TLS_STATIC_SURPLUS 64 + DL_NNS * 100 > +#define TLS_STATIC_SURPLUS 64 + DL_NNS * 176 > > > /* Out-of-memory handler. */ > > > I think you can just put that into the main rseq patch. This change > needs to be mentioned in the commit message, of course. > > With this change, elf/tst-auditmany passes again for me. > > The increase (76 bytes) is larger than 32 bytes because we have not done > this in quite a while. The cost in terms of additional TLS storage is > quite significant, but it will also obscure some initial-exec-related > dlopen failures. OK, done! Thanks, Mathieu > > Conceptually, we could also switch to 64 + (DL_NNS - 1) * 176, an > increase of 1040 bytes over what we have today. > > Thanks, > Florian -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com