From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS17314 8.43.84.0/22 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_HI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5FD891F8C6 for ; Tue, 13 Jul 2021 08:34:16 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8BAF5394FC17 for ; Tue, 13 Jul 2021 08:34:15 +0000 (GMT) Received: from donkey.elm.relay.mailchannels.net (donkey.elm.relay.mailchannels.net [23.83.212.49]) by sourceware.org (Postfix) with ESMTPS id AFAC33939C34 for ; Tue, 13 Jul 2021 08:33:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AFAC33939C34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8E061122684; Tue, 13 Jul 2021 08:33:43 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-17-89.trex.outbound.svc.cluster.local [100.96.17.89]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 264F41225FC; Tue, 13 Jul 2021 08:33:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a18.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.89 (trex/6.3.3); Tue, 13 Jul 2021 08:33:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Scare-White: 34862a1a5de68559_1626165223379_3678533370 X-MC-Loop-Signature: 1626165223379:215943108 X-MC-Ingress-Time: 1626165223379 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id E24D67EFA8; Tue, 13 Jul 2021 01:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=8Gq4o0 QPR06My3ZVFIREVV/kHiY=; b=izqsO56vgd1b3iXV2+dXXcibRfZbL+ISjix4V9 8thYKSL6hPoI85Zc4EOLVIOhMErK5nmyPtI6LmVSDGp/Q65HVnlPnWuOWdTEUHHq ZPHMIvfVypEV/Sqt2nrttwofNy+yuNjgNZtilapoCeb+9TnTf+0JR1enilrsE6Op UrT3s= Received: from [192.168.1.139] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 55C8085B78; Tue, 13 Jul 2021 01:33:40 -0700 (PDT) Subject: Re: [PATCH] csu: Skip ARCH_SETUP_IREL if _dl_relocate_static_pie applied IRELATIVE relocations [BZ #27164] To: Fangrui Song , Carlos O'Donell References: <20210708221032.955550-1-maskray@google.com> <8b8fb5c9-ce4e-b10e-95b1-0281f96894c0@redhat.com> <20210713080646.3n3ycmh3p4d7ul3t@google.com> X-DH-BACKEND: pdx1-sub0-mail-a18 From: Siddhesh Poyarekar Message-ID: <11b630ce-8d50-ee07-37e9-b5fec16a6f18@gotplt.org> Date: Tue, 13 Jul 2021 14:03:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210713080646.3n3ycmh3p4d7ul3t@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" On 7/13/21 1:36 PM, Fangrui Song via Libc-alpha wrote: > A toolchain project can do some workaround for a libc if this choice > makes a large community happy. However, I think it is important not to > take it granted. It is inadequate to just dismiss toolchain developers' > reasonable complaints. The libc should actively fix the issues so that > the toolchain will not need to bear unneeded code in the future. > > I actually have contributed quite a few lld/ELF patches to work around > glibc. For this one I just feel it is not right to just patch lld/ELF > without fixing glibc. What's the utility of having the __rela_iplt{_start,_end} symbols in all binaries other than, maybe, simplifying the static linker implementation? How does it improve things for the generated application code in the end? AFAICT it is doing the opposite by requiring application startup to add a conditional to work around the presence of a redundant symbol. Siddhesh