From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id B239F1F66E for ; Mon, 31 Aug 2020 13:56:48 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C0A5384C005; Mon, 31 Aug 2020 13:56:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C0A5384C005 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1598882207; bh=hQG1Fi6UEH8IIAhHZRWe3IPEYajCQ8OgDULNAbtyumA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DC4NflhMaGHWSmU4pV1sOIaiIX+ViMc5txoc1ThlbInZZJcECUDVpDeHzrps9F2uO xTTJWJgsEktyhQAb2YPueYAqHerpKrJzWrWuUuBH5A0Tbk8umPdlDWQO8rjAzeRF0Q KaayZoTIjFFvHZ7DF9un4+b7BZqsErvk7wxGAYxc= Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by sourceware.org (Postfix) with ESMTPS id 98567386180C for ; Mon, 31 Aug 2020 13:56:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 98567386180C Received: by mail-qk1-x741.google.com with SMTP id p185so6091614qkb.11 for ; Mon, 31 Aug 2020 06:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hQG1Fi6UEH8IIAhHZRWe3IPEYajCQ8OgDULNAbtyumA=; b=oPele3ZprFVyKWwYl0ls+LkdkmN0zN/dcANmfHFGUaQlYaObHLXgEZAZvLKWq7jrsL HCQa7emvXG48xivLMRm5UCmYzguvSpOLQgiYHIT+YRGe+Khs36HIrqPRyL0+/eA2G5DX zIFprXdPlfRGBSD01taSXtJHHkWlfUIV4Mpqig6t2P4iX+1zoYUEFkkk0jroBWTNt68z Ms1FrUMMdS2cJd52t3Iv0+IOXWGiveLlE0aGZ4B1AHn9ajxAs3Qk6ewciPNTeTmc71+O oLcTT3jTi0qeCjm6M19uUBvSXLsUTtT+5XJxoI00yFIIfy+CCes7/VsjE3Ho1j7394Bf 0JEw== X-Gm-Message-State: AOAM532UJNXfHGNWCQCy2ewk4rY2LfVWZTHpi5sU4Cg0EefBGea0DZvd tV1LITe6L+6Ns9aeT9Re9Fk5iLVRQSOHBFdZ X-Google-Smtp-Source: ABdhPJziKm0jPe02I4q1iVp+cvlV1hktbA1DhBBpKLy/y4qttVPjH5KEQg32eKtzQl6YKVKssqFPqw== X-Received: by 2002:a37:8287:: with SMTP id e129mr1364199qkd.132.1598882200912; Mon, 31 Aug 2020 06:56:40 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id x26sm7969977qtr.78.2020.08.31.06.56.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Aug 2020 06:56:40 -0700 (PDT) Subject: Re: [PATCH] Use size_t for mallinfo fields. To: libc-alpha@sourceware.org References: <114d8f81-5960-8e0e-1419-aba03983de59@suse.cz> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <10792cd4-f929-9a3d-a448-c193aff2c1cd@linaro.org> Date: Mon, 31 Aug 2020 10:56:37 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 31/08/2020 10:35, H.J. Lu via Libc-alpha wrote: > On Fri, Aug 28, 2020 at 12:06 PM DJ Delorie via Libc-alpha > wrote: >> >> Martin Li¡ka writes: >> >>> PING^1 >> >> LGTM >> >> Reviewed-by: DJ Delorie >> >>> On 8/12/20 2:29 PM, Martin LiÅ¡ka wrote: >>>> On 8/11/20 7:08 PM, DJ Delorie wrote: >>>>> Florian Weimer writes: >>>>>> DJ, what do you think about this patch? >>>>> >>>>> I have no real problems with the patch, but two minor things that could >>>>> be handled in a follow-up patch... >>>> >>>> Thank you for the review. >>>> Can I read it as ready to go into master? >>>> >>>>> >>>>> 1. The copy code for the old function doesn't handle overflow. We've >>>>>    seen bug reports for this before so should consider the edge cases. >>>>>    IMHO if a size_t value is larger than MAXINT, then MAXINT (or -1) >>>>>    should be stored instead of a randomly truncated value. >>>>> >>>>> 2. The new documentation makes no mention of the older "compatible" >>>>>    interface. >>>>> >>>> >>>> Both comments are valid to me and I can address them in a follow-up patch. >>>> >>>> Martin >> > > $ gcc ../sysdeps/x86_64/multiarch/test-multiarch.c -c -std=gnu11 > -fgnu89-inline -O2 -g -Wall -Wwrite-strings -Wundef -Werror > -fmerge-all-constants -frounding-math -fno-stack-protector > -Wstrict-prototypes -Wold-style-definition -fmath-errno > -fno-stack-protector -DSTACK_PROTECTOR_LEVEL=0 -I../include > -I/export/build/gnu/tools-build/glibc/build-x86_64-linux/csu > -I/export/build/gnu/tools-build/glibc/build-x86_64-linux > -I../sysdeps/unix/sysv/linux/x86_64/64 > -I../sysdeps/unix/sysv/linux/x86_64 > -I../sysdeps/unix/sysv/linux/x86/include > -I../sysdeps/unix/sysv/linux/x86 -I../sysdeps/x86/nptl > -I../sysdeps/unix/sysv/linux/wordsize-64 -I../sysdeps/x86_64/nptl > -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux > -I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu > -I../sysdeps/unix/inet -I../sysdeps/unix/sysv > -I../sysdeps/unix/x86_64 -I../sysdeps/unix -I../sysdeps/posix > -I../sysdeps/x86_64/64 -I../sysdeps/x86_64/fpu/multiarch > -I../sysdeps/x86_64/fpu -I../sysdeps/x86/fpu > -I../sysdeps/x86_64/multiarch -I../sysdeps/x86_64 -I../sysdeps/x86 > -I../sysdeps/ieee754/float128 -I../sysdeps/ieee754/ldbl-96/include > -I../sysdeps/ieee754/ldbl-96 -I../sysdeps/ieee754/dbl-64/wordsize-64 > -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754/flt-32 > -I../sysdeps/wordsize-64 -I../sysdeps/ieee754 -I../sysdeps/generic > -I.. -I../libio -I. -D_LIBC_REENTRANT -include > /export/build/gnu/tools-build/glibc/build-x86_64-linux/libc-modules.h > -DMODULE_NAME=testsuite -include ../include/libc-symbols.h > -DTOP_NAMESPACE=glibc -o > /export/build/gnu/tools-build/glibc/build-x86_64-linux/csu/test-multiarch.o > -MD -MP -MF /export/build/gnu/tools-build/glibc/build-x86_64-linux/csu/test-multiarch.o.dt > -MT /export/build/gnu/tools-build/glibc/build-x86_64-linux/csu/test-multiarch.o > > In file included from ../include/malloc.h:3, > from ../sysdeps/x86_64/multiarch/../../../test-skeleton.c:31, > from ../sysdeps/x86_64/multiarch/test-multiarch.c:96: > ../malloc/malloc.h:118:1: error: empty declaration [-Werror] > 118 | __MALLOC_DEPRECATED; > | ^~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > I hit this today as well, I think the straightforward fix is: diff --git a/malloc/malloc.h b/malloc/malloc.h index e25b33462a..b2371f7704 100644 --- a/malloc/malloc.h +++ b/malloc/malloc.h @@ -115,8 +115,7 @@ struct mallinfo2 }; /* Returns a copy of the updated current mallinfo. */ -__MALLOC_DEPRECATED; -extern struct mallinfo mallinfo (void) __THROW; +extern struct mallinfo mallinfo (void) __THROW __MALLOC_DEPRECATED; /* Returns a copy of the updated current mallinfo. */ extern struct mallinfo2 mallinfo2 (void) __THROW;