From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0AB151F55B for ; Thu, 4 Jun 2020 13:08:56 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A4022388F07A; Thu, 4 Jun 2020 13:08:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A4022388F07A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1591276134; bh=mcVSReUiFdTky5XH5b9w0v/1UfATVllfMaiqPmghLaQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=VrjilV1BR+gkk3xSaETYpkwthieNmQ/AGy6u2eut455Ojyksxrdtr5/eUIbLegRh6 ysA4Hkfz9YNoK79UrrzaFlADWoRaTGvofKrgLJoxiH8zs891c1lmZ+0bBxEuZZ2wmT z/gnWJ7dWplKm9fP5PIZnoWbK/Vlvjy9aBVd3XFY= Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 1352E388F06B for ; Thu, 4 Jun 2020 13:08:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1352E388F06B Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-270-FJCPkJC6P5-JwAPMuhMtoQ-1; Thu, 04 Jun 2020 09:08:50 -0400 X-MC-Unique: FJCPkJC6P5-JwAPMuhMtoQ-1 Received: by mail-qv1-f70.google.com with SMTP id r4so4350697qvh.10 for ; Thu, 04 Jun 2020 06:08:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=mcVSReUiFdTky5XH5b9w0v/1UfATVllfMaiqPmghLaQ=; b=s9bnwSFY6pYnGVy5MhBfOR5EABgelgjNERCy/eGxRKon/hSH4SsAYeZ2O4Sx186oH9 cSBCjL+rCGbra4aIQmcs7M6KBoKQG8/rr3p7lZNsbtWyEmQ63+mgKimpkuyvBLJF0Dzc x5vB3afNrwdIjB50mNGLUudmj3r90l0JcM/bqtaWUnpxdO5K4fBzskm1YE5PGcMP1guH I/IaBtbpX9JGG8Cfl9RDk2vS0WH+y46Nq7vqLyRErFROlqfqKHDXOT12O23QUHYgHrK+ kEZsr/hZ3gQXXA64+bClDJCoW0BAngWp3NjvzB4cv6T80ydvjwtQM7mhu/57yWuSn6K5 Ht5w== X-Gm-Message-State: AOAM53290wvY53C3scjt+ikaF7MesSSZ2z8uW6uPk2PgY7nfTLZtR0Rw W4mBPxNLwA2OBNab0XUQDJicXYVBpl5sXOhlflG7/fnxlHHL1TiemclPz53b1+rEzl9L70/LJhi HthuCPgTRj09BiBr6WkWR X-Received: by 2002:aed:3745:: with SMTP id i63mr4364613qtb.384.1591276129392; Thu, 04 Jun 2020 06:08:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh+VMIfWprSDlCpmVO5QrHAFT183qznQyoFHd9Scoe6jS6yURAHUNekGo5M0GEK4NcY4089w== X-Received: by 2002:aed:3745:: with SMTP id i63mr4364586qtb.384.1591276129106; Thu, 04 Jun 2020 06:08:49 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id d14sm4660482qtr.17.2020.06.04.06.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2020 06:08:48 -0700 (PDT) Subject: Re: [PATCH] nss_dns: Do not call res_dnok in getnetby* implementation To: Florian Weimer , libc-alpha@sourceware.org References: <20190308204424.0744F80DD6B5@oldenburg2.str.redhat.com> Organization: Red Hat Message-ID: <0eca505e-a2d3-867e-60f9-56046e1eaaf1@redhat.com> Date: Thu, 4 Jun 2020 09:08:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20190308204424.0744F80DD6B5@oldenburg2.str.redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carlos O'Donell via Libc-alpha Reply-To: Carlos O'Donell Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 3/8/19 3:44 PM, Florian Weimer wrote: > The argument to res_dnok was produced by ns_name_ntop, so it > is a syntactically valid domain name which, in textual format, > only consists of printable characters. Therefore, the res_dnok > check always passes. > > 2019-03-08 Florian Weimer > > * resolv/nss_dns/dns-network.c (getanswer_r): Do not call > res_dnok. LGTM. Reviewed-by: Carlos O'Donell > diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c > index 4b81b1bfdc..4617b165db 100644 > --- a/resolv/nss_dns/dns-network.c > +++ b/resolv/nss_dns/dns-network.c > @@ -348,7 +348,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, > if (n > 0 && bp[0] == '.') > bp[0] = '\0'; > > - if (n < 0 || res_dnok (bp) == 0) > + if (n < 0) > break; > cp += n; > > @@ -382,7 +382,7 @@ getanswer_r (const querybuf *answer, int anslen, struct netent *result, > n = -1; > } > > - if (n < 0 || !res_hnok (bp)) > + if (n < 0) > { > /* XXX What does this mean? The original form from bind > returns NULL. Incrementing cp has no effect in any case. > -- Cheers, Carlos.