From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 7A5C71F770 for ; Wed, 2 Jan 2019 18:25:11 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=OHVYVMUeywLGlVGQ GLE+XhJPjOrsyAWF8srTVB5x6cjDHSiGGw/BindlsZWe8hDQ/WSa2+Uw8WMtPwyz 9A5HbjeyMo6WoRHvoAt1LuMmOg88GniUX7iHUNGH9N2EU2uYwtXD+OAgOy40csms uw5VaF3We1OoD92na+T+ZnCYYu4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=q4udvML8hQSZmQiyyl92L7 eJ5GY=; b=TUYlKxiSxe2iMGr5PPx6fO4k2id9BlJ6YqVQn3zUDPw6weySREFv++ 7pFIaSClOlFw7aGMftf4eKLS+Jm0jaAh6qH8KI3WJwWqGRYP/lCVl4J3Jn6/G5bo BI1Jv2VtzqtkqaodiYldsS/0X8T1Td3/Y4kWMulOIIJ9gptE5w1EM= Received: (qmail 42258 invoked by alias); 2 Jan 2019 18:25:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 42233 invoked by uid 89); 2 Jan 2019 18:25:08 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: otter.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Name-Shelf: 461a3e856b48667d_1546453502765_493503099 X-MC-Loop-Signature: 1546453502765:1635707346 X-MC-Ingress-Time: 1546453502765 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=q4udvM L8hQSZmQiyyl92L7eJ5GY=; b=winjXgZdM1/1g5oEIZGVkzMjYy1UuogVltHE4E c+aVZ4KDMGrSI0NM84jt1RSkZOvfezhfJBCJLKZYFDCh2DiJc8ptCXWpZlnb4Zyk pw1nLkqgM6beExCYFMg/oO9bSo6JG5ed4jitS1ocWsJHqURvQOlUwJcfFyciA4sw VjLoY= Subject: Re: glibc 2.29 - Winter is coming... To: Rafal Luzynski Cc: GLIBC Devel References: <833db514-f25e-0c41-bf06-b8cc9272f1c2@gotplt.org> <87r2dv495n.fsf@oldenburg2.str.redhat.com> <1188732039.598484.1546429949188@poczta.nazwa.pl> X-DH-BACKEND: pdx1-sub0-mail-a12 From: Siddhesh Poyarekar Message-ID: <0c9a2e87-8b43-725a-d9cc-689ec032ba96@gotplt.org> Date: Wed, 2 Jan 2019 23:54:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: <1188732039.598484.1546429949188@poczta.nazwa.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrudeigddutdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqeenucfkphepuddvfedrvdehvddrvddtvddrudejvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheplgduledvrdduieekrdehrdduudelngdpihhnvghtpeduvdefrddvhedvrddvtddvrddujedvpdhrvghtuhhrnhdqphgrthhhpefuihguughhvghshhcurfhohigrrhgvkhgrrhcuoehsihguughhvghshhesghhothhplhhtrdhorhhgqedpmhgrihhlfhhrohhmpehsihguughhvghshhesghhothhplhhtrdhorhhgpdhnrhgtphhtthhopeguihhgihhtrghlfhhrvggrkheslhhinhhgohhnsghorhhouhhghhdrtghomhenucevlhhushhtvghrufhiiigvpedt On 02/01/19 5:22 PM, Rafal Luzynski wrote: > I have partially reviewed two patches but I don't know whether they are > correct or not and I've asked for more help or for freeze exceptions before: > > [1] Cyrillic -> ASCII transliteration: I am not sure which locale should > implement the feature (C? Russian + few more? All locales with few > exceptions?), > also I am not sure how to deal with digraphs (if an original letter is > uppercase then should the output digraph be all uppercase, like "SH", > or should only the first letter be uppercase, like "Sh"?) This may > happen to be the change in locale data only. I've finally mustered up a bit of courage to read up and give my opinions on this, given that nobody else has. My focus has been on breaking the deadlock because ISTM that the review is stuck on seemingly mundane issues that can either be trivially fixed up later or may not be as serious, such as the choice of implementing in C vs one of the Latin locales or the use of all-caps vs init-caps. However, I am acutely aware that I may not understand the gravity of some of the differences and you're free to throw my opinions out the window :) > [2] [3] Default width for "%Ey" which is important due to the Japanese > era change in 4 months. Also, this patch fixes handling of formatting > flags so if that helps it can be split into the patches fixing the width > issue and fixing the flags issue. A more detailed explanation of what the Japanese era change entails is needed in here, i.e. why is the padding needed and what would the output look like if we don't fix it in this release and why that would be a problem. Other than that, this seems like something we can make an exception for, assuming that it does not affect translations. I personally would have done 2 different patches, but I know others in the community who would have stuck this into a single patch so I don't have too strong an opinion about that aspect of this patch. Siddhesh