From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 17A7C1F466 for ; Tue, 14 Jan 2020 19:42:16 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=XwpaCmHC5f6cu98U h6Ir0z+Rxwi7qhILOxb/oT+eHdfMfBifjeJ6lNRHs8dNtLGdD6/inT8vaUZK/cMZ CmIazsIRZIIuZTR/IBkoVChWrgcAMIhb7jRT6XU12JCeVJ2kDPCW4rKMEU+NjTAp Q5emrFM7g1xG4R+cbkYk6MAhdCw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=Jh3RURhuSCvg1674CA87k6 Qm58o=; b=lz0daPwXd9l8TfbCLVDi9iOKjoOrhLz0sGm3um8HgkQMh4RgSO1QAY 6WrVDp1kWbkzlA6rpFUpsI8k2Fwe51qBgj+Ws5iPA5n6ilSnOU4hd6B56DtsmkUZ Ex7bP3NTG7DWNFJHHivLE0wWtkLZd6ZcLhzqDi436roHiFY1ktfOU= Received: (qmail 117466 invoked by alias); 14 Jan 2020 19:42:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117452 invoked by uid 89); 14 Jan 2020 19:42:12 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: mail-qv1-f68.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Fny4HEYGY18HgcGcCtbKTinuIXIvluoSiKaCAqsExQA=; b=xOr3VQ9F8lKd62LDyzmqYAJHUL9ZvyoEiy1kdr+z75tU7tByEpLftqL/Yzwpm7Llwt 5uaPideohRUeVULarNsgInF+ylCBKlCu20+Lbdq0SisEWKmwNpw2+3M9Mnl1per5+NcG 1AOM/ugIDLpl4Ll7yj2ZTd+DwL7q9oSWfub1DXbSondZ6U+lmqxCVCmN95zE1W0v1DWK quQqCqdOyc/zzKVXOWJ2L01WpiiyEbFhxLKJJbh9K604HNUm2vYdYhEYloMSew5yUIvi jpDQaXdOAdNNoMgmlYyhqINELEskwEta+G5gl+vvi72nWW8nkStrzzul+O0SLnJPggkO meqA== Subject: Re: [PATCH v3 2/3] elf: avoid redundant sort in dlopen To: David Kilroy , "libc-alpha@sourceware.org" References: <1575394197-18006-1-git-send-email-david.kilroy@arm.com> <1575394197-18006-3-git-send-email-david.kilroy@arm.com> From: Adhemerval Zanella Message-ID: <0a4b41eb-0bc8-9f9e-6518-832edd51440c@linaro.org> Date: Tue, 14 Jan 2020 16:41:57 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1575394197-18006-3-git-send-email-david.kilroy@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/12/2019 14:30, David Kilroy wrote: > l_initfini is already sorted by dependency in _dl_map_object_deps(), > so avoid sorting again in dl_open_worker(). > > Tested by running the testsuite on x86_64. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > elf/dl-open.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/elf/dl-open.c b/elf/dl-open.c > index 9996fe9..c4d09c7c 100644 > --- a/elf/dl-open.c > +++ b/elf/dl-open.c > @@ -658,7 +658,6 @@ dl_open_worker (void *a) > l = new->l_initfini[++j]; > } > while (l != NULL); > - _dl_sort_maps (maps, nmaps, NULL, false); > > int relocation_in_progress = 0; > >