Re: [PATCH v3 2/2] ARC: update definitions in elf/elf.h

[Vineet Gupta via Libc-alpha <libc-alpha@sourceware.org>]

On 11/27/22 09:38, Shahab Vahedi via Libc-alpha wrote:
> While porting ARCv2 to elfutils [1], it was brought up that the
> necessary changes to the project's libelf/elf.h must come from
> glibc, because they sync it from glibc [2].  Therefore, this patch
> is to update ARC entries in elf/elf.h.
> 
> The majority of the update is about adding new definitions,
> specially for the relocations.  However, there is one rename, one
> deletion, and one change:
> 
> - R_ARC_JUMP_SLOT renamed to R_ARC_JMP_SLOT to match binutils.
> - R_ARC_B26 removed because it is unused and deprecated.
> - R_ARC_TLS_DTPOFF_S9 changed from 0x4a to the correct value 0x49.
> 
> Finally, a specific SHT class for ARC has been added to glibcelf.py.
> Else, it would result in a collision:
> 
>    _register_elf_h(Sht, ranges=True,
>   File "/src/glibc/scripts/glibcelf.py", line x, in _register_elf_h
>     raise ValueError('duplicate value {}: {}, {}'.format(
>                      ValueError: duplicate value 1879048193:
>                      SHT_ARC_ATTRIBUTES, SHT_X86_64_UNWIND
> 
> [1]
> https://sourceware.org/pipermail/elfutils-devel/2022q4/005530.html
> 
> [2]
> https://sourceware.org/pipermail/elfutils-devel/2022q4/005548.html
> 
> No regression has been observed after applying this patch.  Below
> follows the result:
> 
> UNSUPPORTED: crypt/cert
> UNSUPPORTED: elf/tst-audit22
> FAIL: elf/tst-audit25a
> FAIL: elf/tst-audit25b
> FAIL: elf/tst-bz15311
> FAIL: elf/tst-bz28937
> FAIL: elf/tst-dlmopen4
> UNSUPPORTED: elf/tst-dlopen-self-container
> UNSUPPORTED: elf/tst-dlopen-tlsmodid-container
> UNSUPPORTED: elf/tst-glibc-hwcaps-prepend-cache
> UNSUPPORTED: elf/tst-ldconfig-bad-aux-cache
> UNSUPPORTED: elf/tst-ldconfig-ld_so_conf-update
> UNSUPPORTED: elf/tst-pldd
> UNSUPPORTED: elf/tst-preload-pthread-libc
> XPASS: elf/tst-protected1a
> XPASS: elf/tst-protected1b
> FAIL: elf/tst-tls-allocation-failure-static-patched
> FAIL: elf/tst-tls1
> FAIL: elf/tst-tls3
> FAIL: elf/tst-tlsalign-extern
> UNSUPPORTED: elf/tst-valgrind-smoke
> UNSUPPORTED: grp/tst-initgroups1
> UNSUPPORTED: grp/tst-initgroups2
> UNSUPPORTED: io/tst-getcwd-smallbuff
> UNSUPPORTED: locale/tst-localedef-path-norm
> FAIL: localedata/sort-test
> UNSUPPORTED: localedata/tst-localedef-hardlinks
> FAIL: malloc/tst-malloc-thread-fail-malloc-check
> FAIL: malloc/tst-malloc_info-malloc-check
> UNSUPPORTED: math/test-fesetexcept-traps
> UNSUPPORTED: math/test-fexcept-traps
> UNSUPPORTED: math/test-nearbyint-except
> UNSUPPORTED: math/test-nearbyint-except-2
> UNSUPPORTED: misc/tst-adjtimex
> UNSUPPORTED: misc/tst-clock_adjtime
> FAIL: misc/tst-misalign-clone
> FAIL: misc/tst-misalign-clone-internal
> UNSUPPORTED: misc/tst-ntp_adjtime
> UNSUPPORTED: misc/tst-pkey
> UNSUPPORTED: misc/tst-rseq
> UNSUPPORTED: misc/tst-rseq-disable
> UNSUPPORTED: misc/tst-syslog
> UNSUPPORTED: misc/tst-ttyname
> FAIL: nptl/test-cond-printers
> FAIL: nptl/test-condattr-printers
> FAIL: nptl/test-mutex-printers
> FAIL: nptl/test-mutexattr-printers
> FAIL: nptl/test-rwlock-printers
> FAIL: nptl/test-rwlockattr-printers
> UNSUPPORTED: nptl/tst-pthread-gdb-attach
> UNSUPPORTED: nptl/tst-pthread-gdb-attach-static
> UNSUPPORTED: nptl/tst-pthread-getattr
> UNSUPPORTED: nptl/tst-rseq-nptl
> UNSUPPORTED: nss/tst-nss-compat1
> UNSUPPORTED: nss/tst-nss-db-endgrent
> UNSUPPORTED: nss/tst-nss-db-endpwent
> UNSUPPORTED: nss/tst-nss-files-hosts-long
> UNSUPPORTED: nss/tst-nss-gai-actions
> UNSUPPORTED: nss/tst-nss-test3
> UNSUPPORTED: nss/tst-reload1
> UNSUPPORTED: nss/tst-reload2
> UNSUPPORTED: posix/bug-ga2
> UNSUPPORTED: posix/bug-ga2-mem
> FAIL: posix/globtest
> UNSUPPORTED: posix/tst-vfork3
> UNSUPPORTED: posix/tst-vfork3-mem
> UNSUPPORTED: resolv/mtrace-tst-leaks2
> UNSUPPORTED: resolv/tst-leaks2
> UNSUPPORTED: resolv/tst-resolv-ai_idn
> UNSUPPORTED: resolv/tst-resolv-ai_idn-latin1
> UNSUPPORTED: resolv/tst-resolv-res_init
> UNSUPPORTED: resolv/tst-resolv-res_init-thread
> UNSUPPORTED: rt/tst-bz28213
> UNSUPPORTED: rt/tst-mqueue1
> UNSUPPORTED: rt/tst-mqueue10
> UNSUPPORTED: rt/tst-mqueue2
> UNSUPPORTED: rt/tst-mqueue3
> UNSUPPORTED: rt/tst-mqueue4
> UNSUPPORTED: rt/tst-mqueue5
> UNSUPPORTED: rt/tst-mqueue6
> UNSUPPORTED: rt/tst-mqueue8
> UNSUPPORTED: rt/tst-mqueue8x
> UNSUPPORTED: rt/tst-mqueue9
> UNSUPPORTED: stdlib/test-bz22786
> UNSUPPORTED: stdlib/tst-system
> UNSUPPORTED: string/test-bcopy
> UNSUPPORTED: string/test-memmove
> UNSUPPORTED: string/tst-memmove-overflow
> UNSUPPORTED: string/tst-strerror
> UNSUPPORTED: string/tst-strsignal
> UNSUPPORTED: time/tst-clock_settime
> UNSUPPORTED: time/tst-settimeofday
> Summary of test results:
>       21 FAIL
>     4184 PASS
>       69 UNSUPPORTED
>       16 XFAIL
>        2 XPASS
> 
> Signed-off-by: Shahab Vahedi<shahab@synopsys.com>
> ---

Committed !

Thx,
-Vineet