From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,BODY_8BITS, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 229471F85D for ; Wed, 11 Jul 2018 15:49:53 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:cc:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; q=dns; s=default; b=VN88sFTxWByA9LA9 o9333B9HmveM2CC+kCHbrmTY5l/R2q38NeUX43DTPsAwIzKLQAWe2Q6s4aLHhhwd qrX5jB4l0IkNbriWwZFojBn0MnPbSIS3mr2XRO0drfnU/+vWa7j6Fi66agD+lb4z GNXnRWSuSASRoG5q67FA+o7RxPY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:cc:subject:to:references:from:message-id:date :mime-version:in-reply-to:content-type :content-transfer-encoding; s=default; bh=2A917x+6xgpH+g8IWA4S34 AhvsI=; b=XWBM/5kWpSJg5jeTArhjT2t9HY3Q+annR41tTdNoJtP9MT4YFXYLNZ o2SSiRmnHzQk+KjaazjkUhUOP1UIGkGUQ6oomHo+r6Cqo0x6XiSoVOUSYDNlzNq4 NL7MjUK5acfU+jpCT3W2S2ZmhEHIhYKvbA9oc+2JHN9sOS1Sk2nm4= Received: (qmail 86700 invoked by alias); 11 Jul 2018 15:49:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86687 invoked by uid 89); 11 Jul 2018 15:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJCPXK2H5T8rP2A8QTsF+zVlG5b6xTwPbTvcUOalXEQ=; b=dblGKvV7MmGnlMdQKlfnbGHZ5/oD7TqEZuOw6YFEiOdfwTulIHLQaSoZmlNk4ySK4H6zf5p+eX/aMPV6kli5cZkDZhRGGGE3H9W8WtA8ecW2NYVx9VTy/1Ry5aycIDb9X1w+dKxZ2K7XvFN+yibRxaC3x0zJJ1taQH9ZXe7VH1Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Cc: nd@arm.com Subject: Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions To: Adhemerval Zanella , Florian Weimer , libc-alpha@sourceware.org References: <1517591084-11347-1-git-send-email-adhemerval.zanella@linaro.org> <1517591084-11347-2-git-send-email-adhemerval.zanella@linaro.org> <23dd1909-5ec2-34b7-9672-827251a4be65@redhat.com> <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> From: Szabolcs Nagy Message-ID: <0566f5a5-f56c-7dd9-5ba6-91c67d9633e9@arm.com> Date: Wed, 11 Jul 2018 16:49:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <176c958e-45d6-c1fc-49e4-4eca813d460f@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) On 10/07/18 20:26, Adhemerval Zanella wrote: > > > On 06/07/2018 09:46, Florian Weimer wrote: >> On 02/02/2018 06:04 PM, Adhemerval Zanella wrote: >>> @@ -139,7 +139,9 @@ libpthread-routines = nptl-init vars events version pt-interp \ >>>                 pthread_mutex_getprioceiling \ >>>                 pthread_mutex_setprioceiling \ >>>                 pthread_setname pthread_getname \ >>> -              pthread_setattr_default_np pthread_getattr_default_np >>> +              pthread_setattr_default_np pthread_getattr_default_np \ >>> +              thrd_create thrd_current thrd_detach thrd_equal \ >> >> thrd_current should live in libc, not in libpthread.  Same for thrd_equal, I suppose.  You should just duplicate the comparison, seeing that we haven't done that particular cleanup for pthread_equal yet. >> >> Not sure about thrd_sleep and thrd_yield, but I lean towards libc there as well. > > Right, I added all four symbols (thrd_current, thrd_equal, thrd_sleep, and > thrd_yield) to libc on my personal branch [1] (the change is just to move > the objects from libpthread-routines to routines rule in nptl/Makefile). > I also adjusted the abilist patch with the change. > the abilist patch seems to add sysdeps/unix/sysv/linux/tile/tilegx64/libpthread.abilist i think you can drop that (and update the ChangeLog). > > [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/c11-threads >