From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 88EC41F5AE for ; Thu, 30 Jul 2020 21:46:40 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6B38B3857C5D; Thu, 30 Jul 2020 21:46:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B38B3857C5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1596145599; bh=sPW2VKAKAU1hwzEPDWWXCj1quiSU6EYm3Fm0dtg4YvI=; h=To:References:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ICBUbP3hAxLnJdJEpLpxeL8LjjeRCOGfy0XwqsEmURiNwqvxlUyrr6s50BgZNsyLF TbhC7YVcfAOhL0gBv07tBA9x+25Bk/fgd7QScK9lat2rurptEhsV9wxm7YBcN7MUwo z4PQaUgeQTZnVL0b+2zpU6U6CpZEqnH0aRAgePPA= Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by sourceware.org (Postfix) with ESMTPS id CA7273858D35 for ; Thu, 30 Jul 2020 21:46:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CA7273858D35 Received: by mail-qk1-x741.google.com with SMTP id l64so20276442qkb.8 for ; Thu, 30 Jul 2020 14:46:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=sPW2VKAKAU1hwzEPDWWXCj1quiSU6EYm3Fm0dtg4YvI=; b=haaPVVUNOWpvk/C1GUOJMp2aaCVClIB2YEVR9mXZrlCQMmUFoESdlMlZNoIVdiOh8f vbKpGB+Sn4NrEM29kv84FSxW87Bh6XPwcQGu9vJzH9EAKupKH5i+cr/zaVE8bZVVAdND UP6prSlkSo0tFmkpaL4umFzoaockdDMWNH0IdcIuwr3/wb3+hGB1ck/uSQ8Cj3iRocDz vE/6AucHRDVjm3/pbTc3BvW6/3N0aVimRyxySY4E9yxzb+EZQ5P+NSDxuRLCkzr+3S3z RTkyET+4gz1yxA40fo1qH7fxwX6flxZjckTRc3AJXPEFwkk6SHl9LZXKHLacrWEMltvp jafg== X-Gm-Message-State: AOAM531FUTtV/LnTBmZM6hmZQE1Ffy5/HKnheqRSCL2OPPC6MINiAd7h eFcPoU8hhvY5ZJdluTiZZ7vkr6/Dqhw= X-Google-Smtp-Source: ABdhPJwXxdzvzKyNUL6rGo4GOSfxnGUk0FfFvC4tkKT/uAB6B0NjPPFlewh39EA1TCmzyyR2VPyLHA== X-Received: by 2002:a37:2dc3:: with SMTP id t186mr1221254qkh.157.1596145595332; Thu, 30 Jul 2020 14:46:35 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id v45sm6026823qtc.42.2020.07.30.14.46.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jul 2020 14:46:35 -0700 (PDT) To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20200729205117.2925113-1-adhemerval.zanella@linaro.org> <20200729205117.2925113-4-adhemerval.zanella@linaro.org> <87a6zinhvp.fsf@igel.home> <874kppgem1.fsf@oldenburg2.str.redhat.com> Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 4/5] login: User 64-bit time on struct lastlog Message-ID: <0391514d-3355-03d4-da8a-4be1c97f2b01@linaro.org> Date: Thu, 30 Jul 2020 18:46:32 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <874kppgem1.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Cc: Alistair Francis , Andreas Schwab Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 30/07/2020 13:19, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> On 29/07/2020 18:14, Andreas Schwab wrote: >>> On Jul 29 2020, Adhemerval Zanella via Libc-alpha wrote: >>> >>>> It is not used directly on any symbol, so there is no need to add >>>> compat ones. >>> >>> struct lastlog is an external type, describing the format of >>> /var/log/lastlog. >>> >> >> Right, so which would be best way to handle this transition? My idea >> would to be approach to consumers, shadow-utils developers for instance, >> and state the desirable to make glibc y2038 proof and why this interfaces >> need to be changed. > > Sounds reasonable. We also have a security bug that is related to > direct access to these files: > > > > If we need to mediate access for format translation, maybe this can be > addressed at the same time? I think BZ#24492 is another issue and one that is not easily fixed without some changes on the utmp-file.c internals. The utmp/utmpx files are read by the ut{x} functions and used on programs such as 'who', and to fully avoid possible F_SETLKW deadlocks the write must synchronize using a file not accessible by normal users. The alarm trick mitigates the deadlock issue, but it does not help with the fact the log entry is not generated. The bug report suggestion of using a extra file to act as the lock for write synchronization might be a better option. Another possibility is to move to use a daemon broker to actually operate on utmp/utmpx, but I also think it is out of the scope. I am inclined of using the extra lock file, thoughts?