From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_NONE,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 787481F9FD for ; Mon, 8 Mar 2021 13:06:20 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A7212394EC34; Mon, 8 Mar 2021 13:06:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A7212394EC34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1615208779; bh=6/BUte/NfjO4OU3/jVYS7GexMLC6/AokHaupkpii2Ug=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=B6LxtD1Z54yb3J4A8PfpXOWwrhFWVTPJeimp+u3xjCTTQ/QxLTZhXwY9S0eZaiime e+Vf/wN5JSDY2MQl3/WWjc+NvJ76kYI+le5V+BM0maixXXEaF0OhyICiSOZYUbn1oH vP1IUekcRnDN61tYLniAFxLlUStwrbcdgT86FR4g= Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by sourceware.org (Postfix) with ESMTPS id AA828394D89C for ; Mon, 8 Mar 2021 13:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA828394D89C Received: by mail-qk1-x734.google.com with SMTP id a9so9027316qkn.13 for ; Mon, 08 Mar 2021 05:06:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6/BUte/NfjO4OU3/jVYS7GexMLC6/AokHaupkpii2Ug=; b=QYyvWNh09IES40M9ltMgNhFy1SKGKdARJN8JZtRTbmZbDWlfB+wdk9dFi4EJHtnKbt FKQamAeQGKIZ0FgsJ1jZfqKOiA4ikVRLSizge7FXrpQ52ZTPJzf0fL/vrS6CHINdetio IJ5QXzWSMffo0rFKITHJL8UZT7NRkADlSYOqJVC2JEVzWU9A1CeOaYLnBvPYwwaAaj3g Q8r1ON27vLTN0pHSZt02oHysQyDmSMw7+MTXGlYh2H3f2YkkPQyUCdeQn7YUNflA9gtS 2k4FeAGsSAU/Aokwwnl0TJFzk21KR6bcO9uHGKuZs5/LSrjjm+A+kqnHmNmZaiXV5hel E/9Q== X-Gm-Message-State: AOAM5318nRqQW1Olnw/G7JptLx2WMEPoALoJ8hxuftMGuPqNIw01kdJO jUpXh+zoUOiU4r2aELj2i0lTNsLRUGQZAA== X-Google-Smtp-Source: ABdhPJxEX2xr6q4+dAesGhxl6j4S2xQwLvqn+zpTrgydTFlAfRy9rwngUI/5gQMpy9fZ4qZEssl8cQ== X-Received: by 2002:ae9:f80b:: with SMTP id x11mr20175862qkh.220.1615208776137; Mon, 08 Mar 2021 05:06:16 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id b63sm7556123qkd.84.2021.03.08.05.06.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 05:06:15 -0800 (PST) Subject: Re: [PATCH 43/52] libsupport: Add 64 bit time_t support for stat functions To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210305201518.798584-1-adhemerval.zanella@linaro.org> <20210305201518.798584-44-adhemerval.zanella@linaro.org> <87tupp8h82.fsf@oldenburg.str.redhat.com> Message-ID: <01f025ff-5d89-362c-233b-d36dcf0d3e6f@linaro.org> Date: Mon, 8 Mar 2021 10:06:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87tupp8h82.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Adhemerval Zanella via Libc-alpha Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" On 05/03/2021 17:42, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/support/support-xfstat-time64.c b/support/support-xfstat-time64.c >> new file mode 100644 >> index 0000000000..324c5d20d2 >> --- /dev/null >> +++ b/support/support-xfstat-time64.c >> @@ -0,0 +1,32 @@ >> +/* 64-bit time_t stat with error checking. >> + Copyright (C) 2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library; if not, see >> + . */ >> + >> +/* NB: Non-standard file name to avoid sysdeps override for xstat. >> */ > > The comment seems inappropriate. I think the file name could be > standard: there is no xfstat_time64.c that could be overridden by this. > This applies to the other functions as well. Ack. > > Rest looks okay.