From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-4.3 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 3D70F1F8C6 for ; Thu, 8 Jul 2021 15:16:09 +0000 (UTC) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2266C39DC4D6 for ; Thu, 8 Jul 2021 15:16:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2266C39DC4D6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625757368; bh=PCFPXmyvkNovxHUtpPCAbXGkRopUNBMEUmW1ImzQXYE=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UOuIIYUThr9icXMmuhPUAd5M26JSh20DmgHbyY1upbxIKa0sEwXUKigmpLVouzKL8 Wk55XPFE6QS+hGl7dMzurKRf6CHRUPGlwRuU+5mMFlsjafssqPY5fSNDMvjef+IZz0 iJ2xmOGI4DHo6UqZxGu3OgawWqHjRUmDpjuBfhJw= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A891A399C003 for ; Thu, 8 Jul 2021 15:04:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A891A399C003 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-x3OZ6LA4PZmicJnHQ14-vg-1; Thu, 08 Jul 2021 11:04:34 -0400 X-MC-Unique: x3OZ6LA4PZmicJnHQ14-vg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15863801107 for ; Thu, 8 Jul 2021 15:04:33 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A602D19C66 for ; Thu, 8 Jul 2021 15:04:29 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 17/30] resolv: Remove unnecessary res_isourserver_p call from send_dg In-Reply-To: References: X-From-Line: 0166a598b85d22bb17ae3cda350cf93795f0f8fe Mon Sep 17 00:00:00 2001 Message-Id: <0166a598b85d22bb17ae3cda350cf93795f0f8fe.1625755446.git.fweimer@redhat.com> Date: Thu, 08 Jul 2021 17:04:06 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Florian Weimer via Libc-alpha Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+e=80x24.org@sourceware.org Sender: "Libc-alpha" As the comment indicates, the check is unnecessary due to the way the UDP socket is set up. --- resolv/res_send.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/resolv/res_send.c b/resolv/res_send.c index 77d6835e1a..b6139c7d62 100644 --- a/resolv/res_send.c +++ b/resolv/res_send.c @@ -1343,12 +1343,6 @@ send_dg(res_state statp, return close_and_return_error (statp, resplen2); } - /* Paranoia check. Due to the connected UDP socket, - the kernel has already filtered invalid addresses - for us. */ - if (!res_ourserver_p(statp, &from)) - goto wait; - /* Check for the correct header layout and a matching question. */ int matching_query = 0; /* Default to no matching query. */ -- 2.31.1