From: Szabolcs Nagy <Szabolcs.Nagy@arm.com>
To: GT <tnggil@protonmail.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: PPC64 libmvec sin, cos, sincos
Date: Mon, 4 Mar 2019 14:07:59 +0000 [thread overview]
Message-ID: <009b3ac7-0145-00ef-1b9c-89849a24291d@arm.com> (raw)
In-Reply-To: <7IBtSR-9y3hojcUhrE1RCxG5skB9fFCI7gQ6Q1w-rxfqHNc3Cxed6OuzcO0d6MREORdF_FK7g_k9uOtn1v0-_agUgbqhM0xRY3u1aaH67zg=@protonmail.com>
On 03/03/2019 17:21, GT wrote:
> Here is a suggestion to organize the implementation of the three functions
> a little differently than was done for x86_64.
>
> Because of the trigonometric identity cos (x) = sin( x + PI/2), selecting
> either the sine or cosine polynomial series approximation should suffice to
> compute all three functions.
>
> Defining the series in a static inline function will let us call it with
> input argument x or x +/- PI/2 for sine and cosine (depending on which of the
> two series was chosen). For sincos, the function will be called twice: once
> to obtain the cosines of the inputs and a second time to get the sines.
>
> Doing that will allow us to maintain a single file which performs evaluations
> for the three functions.
>
> Any reason not to implement in this style?
i think it is better to compute
n = rint((x+pi/2)/pi) - 0.5
r = x - n*pi
sin(r)
(current x86_64 vector cos) instead of
n = rint((x+pi/2)/pi)
r = (x+pi/2) - n*pi
sin(r)
since -n*pi can be done with extra precision
(e.g. -n*pi1-n*pi2-n*pi3) but if you pass x+pi/2
down to a common implementation that may have a
large error (e.g. for x close to 0).
so the arg reduction may not be easy to share.
(and the final sign fixup)
but the polynomial can be the same i guess.
prev parent reply other threads:[~2019-03-04 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-03 17:21 PPC64 libmvec sin, cos, sincos GT
2019-03-04 14:07 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/libc/involved.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009b3ac7-0145-00ef-1b9c-89849a24291d@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=tnggil@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).