On 3/20/19 12:03 AM, Lukasz Majewski wrote: > Do you plan to prepare (and send to mailing list) the next version of > this patch (including the above fix)? Sure, attached. > In the time/mktime.c there is: > weak_alias (mktime, timelocal), which makes the timelocal calls > aliases to mktime for time_t 32 and 64 bit (for Y2038 the proper > __REDIRECT will be added). > Sorry, I'm a bit lost here. How will that __REDIRECT work, exactly? > Should it be part of this patch, or part of a later patch? > The __REDIRECT would be a part of the latter patch - the one which adds > Y2038 support for 32 bit SoCs. > > It would simply redirect calls to mktime/timegm to internal > __mktime64()/__timegm64(). > OK, in that case, it can redirect timelocal calls to __mktime64, and there is no need for a __timelocal64.