mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Stefan Beller <>
Cc: Jonathan Nieder <>,
	"git\" <>
Subject: Re: [PATCH] checkout: do not mention detach advice for explicit --detach option
Date: Thu, 11 Aug 2016 11:09:35 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Stefan Beller's message of "Wed, 10 Aug 2016 15:46:11 -0700")

Stefan Beller <> writes:

> On Wed, Aug 10, 2016 at 10:32 AM, Jonathan Nieder <> wrote:
>> Stefan Beller wrote:
>>> When a user asked for a detached HEAD specifically with `--detach`,
>>> we do not need to give advice on what a detached HEAD state entails as
>>> we can assume they know what they're getting into as they asked for it.
>> Example? Tests?
> There are no tests for the advice things IIUC.

There seem to already be tests that explicitly sets advice.* to true
like in t7201 and t7512, but even if there weren't any existing
ones, it would be appropriate to make sure that an explicit --detach
does not trigger the advice, even when advice.detachedHEAD left
unconfigured (or set to true), given that doing so is the whole
purpose of this patch, I would think.

  reply	other threads:[~2016-08-11 18:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 17:28 [PATCH] checkout: do not mention detach advice for explicit --detach option Stefan Beller
2016-08-10 17:32 ` Jonathan Nieder
2016-08-10 22:46   ` Stefan Beller
2016-08-11 18:09     ` Junio C Hamano [this message]
2016-08-10 18:00 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).