From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, "Dan Jacques" <dnj@google.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 0/3] Some add-on patches on top of dj/runtime-prefix
Date: Tue, 24 Apr 2018 10:44:27 +0900 [thread overview]
Message-ID: <xmqqzi1t74zo.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <cover.1524309209.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Sat, 21 Apr 2018 13:13:48 +0200 (DST)")
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> We carried a slightly different version of the git_setup_gettext() patch
> (which took care of releasing the buffer allocated by system_path()),
> and we carry two more patches that touch the same area, so now that
> dj/runtime-prefix hit `next`, it seems a good time to contribute those,
> too.
>
> Changes since v1:
>
> - clarified in v1 why we cannot simply force users to recompile with NO_GETTEXT
> instead.
>
>
> Johannes Schindelin (2):
> gettext: avoid initialization if the locale dir is not present
> git_setup_gettext: plug memory leak
>
> Philip Oakley (1):
> Avoid multiple PREFIX definitions
>
> Makefile | 2 +-
> exec-cmd.c | 4 ++--
> gettext.c | 10 +++++++++-
> sideband.c | 10 +++++-----
> 4 files changed, 17 insertions(+), 9 deletions(-)
>
>
> base-commit: b46fe60e1d7235603a29499822493bd3791195da
Basing your work on the tip of 'next' is good for discussion, but
not readily usable for final application. Let me see if I can
untangle the dependents to come up with a reasonable base.
The changes themselves looked reasonable. Thanks.
next prev parent reply other threads:[~2018-04-24 1:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:03 [PATCH 0/3] Some add-on patches on top of dj/runtime-prefix Johannes Schindelin
2018-04-20 8:03 ` [PATCH 1/3] gettext: avoid initialization if the locale dir is not present Johannes Schindelin
2018-04-20 9:59 ` Ævar Arnfjörð Bjarmason
2018-04-20 10:54 ` Martin Ågren
2018-04-20 11:18 ` Ævar Arnfjörð Bjarmason
2018-04-20 19:35 ` Johannes Schindelin
2018-04-21 7:43 ` Ævar Arnfjörð Bjarmason
2018-04-21 10:17 ` Johannes Schindelin
2018-04-20 8:03 ` [PATCH 2/3] git_setup_gettext: plug memory leak Johannes Schindelin
2018-04-20 8:04 ` [PATCH 3/3] Avoid multiple PREFIX definitions Johannes Schindelin
2018-04-22 15:32 ` Philip Oakley
2018-04-21 11:13 ` [PATCH v2 0/3] Some add-on patches on top of dj/runtime-prefix Johannes Schindelin
2018-04-21 11:14 ` [PATCH v2 1/3] gettext: avoid initialization if the locale dir is not present Johannes Schindelin
2018-04-21 11:14 ` [PATCH v2 2/3] git_setup_gettext: plug memory leak Johannes Schindelin
2018-04-21 11:18 ` [PATCH v2 3/3] Avoid multiple PREFIX definitions Johannes Schindelin
2018-04-24 1:44 ` Junio C Hamano [this message]
2018-04-24 1:50 ` [PATCH v2 0/3] Some add-on patches on top of dj/runtime-prefix Junio C Hamano
2018-04-24 2:41 ` Junio C Hamano
2018-04-24 14:48 ` Johannes Schindelin
2018-04-25 1:28 ` Junio C Hamano
2018-04-25 7:46 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzi1t74zo.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dnj@google.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).