* [PATCH] docs: link to gitsubmodules
@ 2018-06-05 20:24 Brandon Williams
2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Brandon Williams @ 2018-06-05 20:24 UTC (permalink / raw)
To: git; +Cc: Brandon Williams
Add a link to gitsubmodules(7) under the `submodule.active` entry in
git-config(1).
Signed-off-by: Brandon Williams <bmwill@google.com>
---
Documentation/config.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index ab641bf5a..1277731aa 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -3327,12 +3327,13 @@ submodule.<name>.ignore::
submodule.<name>.active::
Boolean value indicating if the submodule is of interest to git
commands. This config option takes precedence over the
- submodule.active config option.
+ submodule.active config option. See linkgit:git-submodule[1] for
+ details.
submodule.active::
A repeated field which contains a pathspec used to match against a
submodule's path to determine if the submodule is of interest to git
- commands.
+ commands. See linkgit:git-submodule[1] for details.
submodule.recurse::
Specifies if commands recurse into submodules by default. This
--
2.17.1.1185.g55be947832-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] docs: link to gitsubmodules
2018-06-05 20:24 [PATCH] docs: link to gitsubmodules Brandon Williams
@ 2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
2018-06-05 20:39 ` Brandon Williams
2018-06-05 20:37 ` Jonathan Nieder
2018-06-20 21:50 ` [PATCH v2] " Brandon Williams
2 siblings, 1 reply; 8+ messages in thread
From: Ævar Arnfjörð Bjarmason @ 2018-06-05 20:35 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
On Tue, Jun 05 2018, Brandon Williams wrote:
> Add a link to gitsubmodules(7) under the `submodule.active` entry in
> git-config(1).
Did you mean to change either the subject or content of this patch? Your
subject says gitsubmodules(7), but you link to git-submodule(1).
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] docs: link to gitsubmodules
2018-06-05 20:24 [PATCH] docs: link to gitsubmodules Brandon Williams
2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
@ 2018-06-05 20:37 ` Jonathan Nieder
2018-06-05 20:39 ` Jonathan Nieder
2018-06-20 21:50 ` [PATCH v2] " Brandon Williams
2 siblings, 1 reply; 8+ messages in thread
From: Jonathan Nieder @ 2018-06-05 20:37 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
Hi,
Brandon Williams wrote:
> Add a link to gitsubmodules(7) under the `submodule.active` entry in
> git-config(1).
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> Documentation/config.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index ab641bf5a..1277731aa 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -3327,12 +3327,13 @@ submodule.<name>.ignore::
> submodule.<name>.active::
> Boolean value indicating if the submodule is of interest to git
> commands. This config option takes precedence over the
> - submodule.active config option.
> + submodule.active config option. See linkgit:git-submodule[1] for
> + details.
This takes the user to gitsubmodules(7), but with a hop to
git-submodule(1) along the way there:
DESCRIPTION
Inspects, updates and manages submodules.
For more information about submodules, see gitsubmodules(7).
I suppose I'd prefer that it links directly to
linkgit:gitsubmodules[7] just because that would steer people toward
commands like "git checkout --recurse-submodules" instead of "git
submodule init".
With or without that tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Tested using
make -C Documentation/ git-config.1
man Documentation/git-config.1
Thanks,
Jonathan
diff --git i/Documentation/config.txt w/Documentation/config.txt
index 1277731aa4..efbd7e5652 100644
--- i/Documentation/config.txt
+++ w/Documentation/config.txt
@@ -3327,13 +3327,13 @@ submodule.<name>.ignore::
submodule.<name>.active::
Boolean value indicating if the submodule is of interest to git
commands. This config option takes precedence over the
- submodule.active config option. See linkgit:git-submodule[1] for
+ submodule.active config option. See linkgit:gitsubmodules[7] for
details.
submodule.active::
A repeated field which contains a pathspec used to match against a
submodule's path to determine if the submodule is of interest to git
- commands. See linkgit:git-submodule[1] for details.
+ commands. See linkgit:gitsubmodule[7] for details.
submodule.recurse::
Specifies if commands recurse into submodules by default. This
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] docs: link to gitsubmodules
2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
@ 2018-06-05 20:39 ` Brandon Williams
0 siblings, 0 replies; 8+ messages in thread
From: Brandon Williams @ 2018-06-05 20:39 UTC (permalink / raw)
To: Ævar Arnfjörð Bjarmason; +Cc: git
On 06/05, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Jun 05 2018, Brandon Williams wrote:
>
> > Add a link to gitsubmodules(7) under the `submodule.active` entry in
> > git-config(1).
>
> Did you mean to change either the subject or content of this patch? Your
> subject says gitsubmodules(7), but you link to git-submodule(1).
Yep I meant for it to be to gitsubmodules(7), turns out I don't know how
our documentation is built :)
--
Brandon Williams
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] docs: link to gitsubmodules
2018-06-05 20:37 ` Jonathan Nieder
@ 2018-06-05 20:39 ` Jonathan Nieder
2018-06-05 20:40 ` Brandon Williams
0 siblings, 1 reply; 8+ messages in thread
From: Jonathan Nieder @ 2018-06-05 20:39 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
Jonathan Nieder wrote:
> --- i/Documentation/config.txt
> +++ w/Documentation/config.txt
> @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::
> submodule.<name>.active::
> Boolean value indicating if the submodule is of interest to git
> commands. This config option takes precedence over the
> - submodule.active config option. See linkgit:git-submodule[1] for
> + submodule.active config option. See linkgit:gitsubmodules[7] for
> details.
>
> submodule.active::
> A repeated field which contains a pathspec used to match against a
> submodule's path to determine if the submodule is of interest to git
> - commands. See linkgit:git-submodule[1] for details.
> + commands. See linkgit:gitsubmodule[7] for details.
Gah, and I can't spell. This one should have been
linkgit:gitsubmodules[7]. Updated diff below. Tested using
make -C Documentation/ git-config.html gitsubmodules.html
w3m Documentation/git-config.html
Thanks and sorry for the noise,
Jonathan
diff --git i/Documentation/config.txt w/Documentation/config.txt
index 1277731aa4..340eb1f3c4 100644
--- i/Documentation/config.txt
+++ w/Documentation/config.txt
@@ -3327,13 +3327,13 @@ submodule.<name>.ignore::
submodule.<name>.active::
Boolean value indicating if the submodule is of interest to git
commands. This config option takes precedence over the
- submodule.active config option. See linkgit:git-submodule[1] for
+ submodule.active config option. See linkgit:gitsubmodules[7] for
details.
submodule.active::
A repeated field which contains a pathspec used to match against a
submodule's path to determine if the submodule is of interest to git
- commands. See linkgit:git-submodule[1] for details.
+ commands. See linkgit:gitsubmodules[7] for details.
submodule.recurse::
Specifies if commands recurse into submodules by default. This
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] docs: link to gitsubmodules
2018-06-05 20:39 ` Jonathan Nieder
@ 2018-06-05 20:40 ` Brandon Williams
0 siblings, 0 replies; 8+ messages in thread
From: Brandon Williams @ 2018-06-05 20:40 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: git
On 06/05, Jonathan Nieder wrote:
> Jonathan Nieder wrote:
>
> > --- i/Documentation/config.txt
> > +++ w/Documentation/config.txt
> > @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::
> > submodule.<name>.active::
> > Boolean value indicating if the submodule is of interest to git
> > commands. This config option takes precedence over the
> > - submodule.active config option. See linkgit:git-submodule[1] for
> > + submodule.active config option. See linkgit:gitsubmodules[7] for
> > details.
> >
> > submodule.active::
> > A repeated field which contains a pathspec used to match against a
> > submodule's path to determine if the submodule is of interest to git
> > - commands. See linkgit:git-submodule[1] for details.
> > + commands. See linkgit:gitsubmodule[7] for details.
>
> Gah, and I can't spell. This one should have been
> linkgit:gitsubmodules[7]. Updated diff below. Tested using
>
> make -C Documentation/ git-config.html gitsubmodules.html
> w3m Documentation/git-config.html
>
> Thanks and sorry for the noise,
> Jonathan
>
> diff --git i/Documentation/config.txt w/Documentation/config.txt
> index 1277731aa4..340eb1f3c4 100644
> --- i/Documentation/config.txt
> +++ w/Documentation/config.txt
> @@ -3327,13 +3327,13 @@ submodule.<name>.ignore::
> submodule.<name>.active::
> Boolean value indicating if the submodule is of interest to git
> commands. This config option takes precedence over the
> - submodule.active config option. See linkgit:git-submodule[1] for
> + submodule.active config option. See linkgit:gitsubmodules[7] for
> details.
>
> submodule.active::
> A repeated field which contains a pathspec used to match against a
> submodule's path to determine if the submodule is of interest to git
> - commands. See linkgit:git-submodule[1] for details.
> + commands. See linkgit:gitsubmodules[7] for details.
>
> submodule.recurse::
> Specifies if commands recurse into submodules by default. This
Yep this is what I meant.
--
Brandon Williams
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] docs: link to gitsubmodules
2018-06-05 20:24 [PATCH] docs: link to gitsubmodules Brandon Williams
2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
2018-06-05 20:37 ` Jonathan Nieder
@ 2018-06-20 21:50 ` Brandon Williams
2018-06-21 20:58 ` Junio C Hamano
2 siblings, 1 reply; 8+ messages in thread
From: Brandon Williams @ 2018-06-20 21:50 UTC (permalink / raw)
To: git; +Cc: Brandon Williams
Add a link to gitsubmodules(7) under the `submodule.active` entry in
git-config(1).
Signed-off-by: Brandon Williams <bmwill@google.com>
---
Documentation/config.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index ab641bf5a..340eb1f3c 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -3327,12 +3327,13 @@ submodule.<name>.ignore::
submodule.<name>.active::
Boolean value indicating if the submodule is of interest to git
commands. This config option takes precedence over the
- submodule.active config option.
+ submodule.active config option. See linkgit:gitsubmodules[7] for
+ details.
submodule.active::
A repeated field which contains a pathspec used to match against a
submodule's path to determine if the submodule is of interest to git
- commands.
+ commands. See linkgit:gitsubmodules[7] for details.
submodule.recurse::
Specifies if commands recurse into submodules by default. This
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] docs: link to gitsubmodules
2018-06-20 21:50 ` [PATCH v2] " Brandon Williams
@ 2018-06-21 20:58 ` Junio C Hamano
0 siblings, 0 replies; 8+ messages in thread
From: Junio C Hamano @ 2018-06-21 20:58 UTC (permalink / raw)
To: Brandon Williams; +Cc: git
Brandon Williams <bmwill@google.com> writes:
> Add a link to gitsubmodules(7) under the `submodule.active` entry in
> git-config(1).
>
> Signed-off-by: Brandon Williams <bmwill@google.com>
> ---
> Documentation/config.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks.
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index ab641bf5a..340eb1f3c 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -3327,12 +3327,13 @@ submodule.<name>.ignore::
> submodule.<name>.active::
> Boolean value indicating if the submodule is of interest to git
> commands. This config option takes precedence over the
> - submodule.active config option.
> + submodule.active config option. See linkgit:gitsubmodules[7] for
> + details.
>
> submodule.active::
> A repeated field which contains a pathspec used to match against a
> submodule's path to determine if the submodule is of interest to git
> - commands.
> + commands. See linkgit:gitsubmodules[7] for details.
>
> submodule.recurse::
> Specifies if commands recurse into submodules by default. This
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-06-21 20:58 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 20:24 [PATCH] docs: link to gitsubmodules Brandon Williams
2018-06-05 20:35 ` Ævar Arnfjörð Bjarmason
2018-06-05 20:39 ` Brandon Williams
2018-06-05 20:37 ` Jonathan Nieder
2018-06-05 20:39 ` Jonathan Nieder
2018-06-05 20:40 ` Brandon Williams
2018-06-20 21:50 ` [PATCH v2] " Brandon Williams
2018-06-21 20:58 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).