mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Beat Bolli <>
Subject: Re: [PATCH v4] Makefile: add a DEVOPTS flag to get pedantic compilation
Date: Wed, 25 Jul 2018 09:57:49 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Beat Bolli's message of "Tue, 24 Jul 2018 21:26:43 +0200")

Beat Bolli <> writes:

> In the interest of code hygiene, make it easier to compile Git with the
> flag -pedantic.
> Pure pedantic compilation with GCC 7.3 results in one warning per use of
> the translation macro `N_`:
>     warning: array initialized from parenthesized string constant [-Wpedantic]
> Therefore also disable the parenthesising of i18n strings with
> Signed-off-by: Beat Bolli <>
> ---

Hmph, what did you change between v3 and v4?

> diff --git a/Makefile b/Makefile
> index 0cb6590f24..2bfc051652 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -484,6 +484,12 @@ all::

The postimage of this hunk is supposed to be 11 lines long, as you
have five additional line in the middle of 6 original context lines.
Where did this 12 come from?  I am only interested in finding out if
our patch generation tool(s) have some bugs with this question.

If this is only because you hand-edit your patch, then we have no
tool breakage to worry about, but please refrain from doing so in
the future (instead always go back to the commit, amend it, and
re-run format-patch).


>  #        The DEVELOPER mode enables -Wextra with a few exceptions. By
>  #        setting this flag the exceptions are removed, and all of
>  #        -Wextra is used.
> +#
> +#    pedantic:
> +#
> +#        Enable -pedantic compilation. This also disables
> +#        USE_PARENS_AROUND_GETTEXT_N to produce only relevant warnings.

  reply	other threads:[~2018-07-25 16:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 20:36 [PATCH v2] Makefile: add a DEVOPTS flag to get pedantic compilation Beat Bolli
2018-07-23 18:53 ` Junio C Hamano
2018-07-24  6:04   ` Beat Bolli
2018-07-24 13:21     ` Junio C Hamano
2018-07-24 17:13       ` [PATCH v3] " Beat Bolli
2018-07-24 19:26         ` [PATCH v4] " Beat Bolli
2018-07-25 16:57           ` Junio C Hamano [this message]
2018-07-25 17:38             ` Beat Bolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).