From: Junio C Hamano <gitster@pobox.com>
To: Ben Peart <peartben@gmail.com>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
Ben Peart <benpeart@microsoft.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Ben Peart <Ben.Peart@microsoft.com>
Subject: Re: [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support
Date: Fri, 14 Sep 2018 09:20:26 -0700 [thread overview]
Message-ID: <xmqqzhwkcaph.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <0a3baaf6-f71b-e8f9-7445-8bf2b5d3513e@gmail.com> (Ben Peart's message of "Fri, 14 Sep 2018 09:50:05 -0400")
Ben Peart <peartben@gmail.com> writes:
>> I think it is OK to make it error only if the old one is set without
>> the new one. Then people can have _both_ set to the same value
>> during the period in which the topic sails through pu down to next
>> down to master, after seeing an failure once while building and
>> testing 'pu'.
>>
>
> I'll make it a warning if they are both set so that people are
> reminded to remove the old variable and an error if only the old one
> is set so people know to update their environment.
After the topic graduates to a stable release (or two), it would be
a good addition to encourage people to clean things up, of course,
but doing so too early by warning when they are both set is not a
good idea, I would think. It would bring us back to "the user has
to futz with config.mak every time switching between 'maint' and
'next'".
> I'll combine all these into a single patch series. It grew as I
> discovered more that needed to be updated.
Thanks.
I didn't mind it too much to have them as independent patches. It
at least helped me forcing myself to give closer look at them ;-)
next prev parent reply other threads:[~2018-09-14 16:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 21:26 [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support Ben Peart
2018-09-12 22:31 ` Thomas Gummerer
2018-09-13 14:07 ` Ben Peart
2018-09-13 21:56 ` Thomas Gummerer
2018-09-13 22:08 ` Junio C Hamano
2018-09-14 13:50 ` Ben Peart
2018-09-14 16:20 ` Junio C Hamano [this message]
2018-09-13 18:17 ` [PATCH v2] read-cache: update TEST_GIT_INDEX_VERSION support Ben Peart
2018-09-13 18:49 ` [PATCH v1] read-cache: add GIT_TEST_INDEX_VERSION support Ævar Arnfjörð Bjarmason
2018-09-13 20:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhwkcaph.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Ben.Peart@microsoft.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).