From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2019, #03; Wed, 13)
Date: Thu, 14 Feb 2019 12:47:06 -0800 [thread overview]
Message-ID: <xmqqzhqy6qt1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190214201006.127960-1-jonathantanmy@google.com> (Jonathan Tan's message of "Thu, 14 Feb 2019 12:10:06 -0800")
Jonathan Tan <jonathantanmy@google.com> writes:
>> * jt/test-protocol-version (2019-02-06) 9 commits
>> - remote-curl: in v2, fill credentials if needed
>> - t5552: compensate for v2 filtering ref adv.
>> - tests: fix protocol version for overspecifications
>> - t5700: only run with protocol version 1
>> - t5512: compensate for v0 only sending HEAD symrefs
>> - t5503: fix overspecification of trace expectation
>> - tests: always test fetch of unreachable with v0
>> - tests: define GIT_TEST_PROTOCOL_VERSION
>> - Merge branch 'js/protocol-advertise-multi' into jt/test-protocol-version
>> (this branch uses js/protocol-advertise-multi.)
>>
>> Help developers by making it easier to run most of the tests under
>> different versions of over-the-wire protocols.
>>
>> Blocked by js/protocol-advertise-multi
>
> If you don't mind, remove the last patch (remote-curl: in v2, fill
> credentials if needed) from this set. Peff noticed some issues with it,
> and I have sent out a separate set [1] that better fixes the issue.
I certainly do not mind ;-) Thanks for a ping & an update.
> Peff also noticed [2] a minor issue with patch 1 - I used
> strlen(git_test_v) instead of *git_test_v to check that it is non-empty
> - but that might not be worth a reroll.
>
> Other than that, this set (with the exception of the last patch that I
> asked you to remove in the first paragraph) looks good to Peff [3] and
> me (besides being blocked by js/protocol-advertise-multi).
Let's see if we can straighten out the blocker first, then, so that
we can reboot both topics once the current cycle closes.
Thanks.
prev parent reply other threads:[~2019-02-14 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 3:33 What's cooking in git.git (Feb 2019, #03; Wed, 13) Junio C Hamano
2019-02-14 3:59 ` Jeff King
2019-02-14 5:49 ` Junio C Hamano
2019-02-14 5:53 ` Jeff King
2019-02-14 6:49 ` Todd Zullinger
2019-02-14 6:54 ` Jeff King
2019-02-14 20:10 ` Jonathan Tan
2019-02-14 20:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhqy6qt1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).