From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing list" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Subject: Re: [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch
Date: Mon, 18 Mar 2019 14:23:09 +0900 [thread overview]
Message-ID: <xmqqzhps4uyq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRMiEcXVRYrgp+B3tcDreh41-a5_k0zABe+HNce0G=Cyw@mail.gmail.com> (Eric Sunshine's message of "Fri, 15 Mar 2019 15:00:56 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> So, I'm fairly negative on this change. However, that doesn't mean I
> would oppose tweaking the value shared between the two programs (and
> also the default used by GitGitGadget, if it specifies it manually),
> though I defer to Dscho in that regard.
I do not think of a good reason why the command should behave
differently only when run from inside format-patch, and if we were
changing anything, perhaps raising it a bit for all may make sense.
I have yet to see range-diff getting confused and matching wrong
patches but often seee it being too conservative to match two
iterations of the same patch after a moderate amount of update.
I find myself passing "--creation-factor 99" or some absurdly
looking value when accepting a rerolled series. The most recent was
the updated 'clean-up merge message with scissors' from Denton
[*1*].
[Footnote]
*1* <6716d28a5187c44c1d90f5ce840c44441f62352c.1552275703.git.liu.denton@gmail.com>
and <08426189b5a29b376581eb0172e52222ab22387a.1552817044.git.liu.denton@gmail.com>
do not line up without a high creation factor.
prev parent reply other threads:[~2019-03-18 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 16:09 [WIP PATCH/RFC] Use a higher range-diff --creation-factor for format-patch Ævar Arnfjörð Bjarmason
2019-03-15 19:00 ` Eric Sunshine
2019-03-15 19:21 ` Ævar Arnfjörð Bjarmason
2019-03-21 11:22 ` Johannes Schindelin
2019-03-18 5:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhps4uyq.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).