From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: ab/send-email-transferencoding-fix, was Re: What's cooking in git.git (May 2019, #04; Tue, 28)
Date: Wed, 29 May 2019 12:54:28 -0700 [thread overview]
Message-ID: <xmqqzhn5xci3.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1905292009030.44@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 29 May 2019 20:10:09 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> Yeah, I recall that one from previous week. Let's queue it on top
>> (and find the right place tos quash it in).
>
> Sorry, I was unclear. The commit to amend is the tip one: "send-email: fix
> regression in sendemail.identity parsing".
No need to be sorry---I found it out after applying and for a single
liner, it is trivial to see which commit it needs to be squashed
into ;)
FWIW, I learned to try to respond as early as possible to help
unblock other people, and as a consequence, my response may come
before I know exactly what the task is, or when I can get to the
task that I promise in my response. When I wrote the above, I
didn't exactly recall how many tests your follow-up patch I saw
earlier (or the one you sent this time) was adding prerequisites,
and I didn't yet know how involved it would be to find where it
applies when I wrote my response.
prev parent reply other threads:[~2019-05-29 19:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 22:08 What's cooking in git.git (May 2019, #04; Tue, 28) Junio C Hamano
2019-05-28 22:26 ` Jeff King
2019-05-29 16:53 ` Junio C Hamano
2019-05-30 11:51 ` Jeff King
2019-05-30 15:01 ` Johannes Schindelin
2019-05-30 18:29 ` Derrick Stolee
2019-05-29 12:26 ` ab/send-email-transferencoding-fix, was " Johannes Schindelin
2019-05-29 12:36 ` Ævar Arnfjörð Bjarmason
2019-05-29 17:31 ` Junio C Hamano
2019-05-29 18:10 ` Johannes Schindelin
2019-05-29 19:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhn5xci3.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).