From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
Cameron Gunnin <cameron.gunnin@synopsys.com>
Subject: Re: [PATCH 0/3] git-worktree: fix "add" being fooled by suffix matching
Date: Mon, 24 Feb 2020 13:02:49 -0800 [thread overview]
Message-ID: <xmqqzhd7og06.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200224090848.54321-1-sunshine@sunshineco.com> (Eric Sunshine's message of "Mon, 24 Feb 2020 04:08:45 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
> Rather than adding more band-aids to the validation to work around magic
> matching performed by find_worktree(), this patch series fixes the
> problem once and for all by locating a worktree deterministically based
> only on pathname.
Makes sense. I wonder if strange synonyms that make more than one
paths string refer to the same filesystem entity (read: case
insensitive or unicode smashing filesystems Windows and macintoshes
use) have similar effect on the codepath, and if so, if we want to
do anything about it (my personal answers are "I don't know but I
would not be surprised if it is the case" and "No, just tell users
not to hurt themselves and move on").
Will queue. Thanks.
prev parent reply other threads:[~2020-02-24 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 23:50 BUG: git worktree add directory-path fails due to over-aggressive disallowing of worktrees with same suffix Cameron Gunnin
2019-02-12 22:44 ` Eric Sunshine
2020-02-24 9:08 ` [PATCH 0/3] git-worktree: fix "add" being fooled by suffix matching Eric Sunshine
2020-02-24 9:08 ` [PATCH 1/3] worktree: improve find_worktree() documentation Eric Sunshine
2020-02-24 9:08 ` [PATCH 2/3] worktree: add utility to find worktree by pathname Eric Sunshine
2020-02-24 9:08 ` [PATCH 3/3] worktree: don't allow "add" validation to be fooled by suffix matching Eric Sunshine
2020-02-24 21:06 ` Junio C Hamano
2020-02-24 21:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzhd7og06.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=cameron.gunnin@synopsys.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).