git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: peff@peff.net, Adrian Wijaya <adrianwijaya100@gmail.com>
Subject: Re: [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file"
Date: Fri, 20 Mar 2020 11:08:40 -0700	[thread overview]
Message-ID: <xmqqzhcac313.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200320160723.15190-1-adrianwijaya100@gmail.com> (Adrian Wijaya's message of "Fri, 20 Mar 2020 23:07:23 +0700")

Adrian Wijaya <adrianwijaya100@gmail.com> writes:

>  	test "z$(git config --file=notyet test.frotz)" = znitfol &&

We see 130+ instances of this rather antiquated construct that
presumably avoids to compare an empty string with something else
using "test X = Y" tool.  It might have been a good idea in 2005 (I
do not remember why we started doing this), but perhaps it is time
to clean them up by listing it as another microproject idea for the
next year?


  parent reply	other threads:[~2020-03-20 18:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19 23:47 [GSOC][PATCH 1/2] t1300: replace "test -f" into "test_path_is_file" Adrian Wijaya
2020-03-19 23:47 ` [GSOC][PATCH 2/2] " Adrian Wijaya
2020-03-20  5:52   ` Jeff King
2020-03-20 15:22     ` adrian wijaya
2020-03-20 15:45 ` [GSOC][PATCH 1/2] " adrian wijaya
2020-03-20 16:07   ` [GSOC][PATCH v2] t1300: convert "test -f" with "test_path_is_file" Adrian Wijaya
2020-03-20 18:04     ` Junio C Hamano
2020-03-20 18:08     ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-03-20 15:56 Adrian Wijaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhcac313.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=adrianwijaya100@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).