git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Solomon Ucko <solly.ucko@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: rebase -i: quick/inline reword
Date: Wed, 06 May 2020 21:52:19 -0700	[thread overview]
Message-ID: <xmqqzhak4a9o.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CANtMP6oKN6Ueu=fqFYv2VhUP5S-ifbSzPTARvbEg4eV0pcRcHw@mail.gmail.com> (Solomon Ucko's message of "Thu, 7 May 2020 00:27:16 -0400")

Solomon Ucko <solly.ucko@gmail.com> writes:

> ... It would be much easier
> if there were a mode where any changes to the commit titles in the list
> modified the commits' titles. Maybe `git rebase -i --reword`?
>
> Any thoughts, suggestions, questions, etc.?

It is probably a bad idea, as it encourages a single-liner commit
message without any body.

Equally a bad idea, but perhaps slightly less evil, would be to add
a new verb that can be used to replace "pick" with, say, "retitle",
and teach the sequencing machinery to pay attention to the updated
title line only in that case.

Besides, neither is really workable, as the single line text after
the abbreviated commit object name in the todo list is meant as an
output only "informational" comment on each step, and there are
plans to add more than just the squashed title paragraph there
(cf. *1* for an example).  Even without such a future change, the
material there may not be just the commit title, if I am reading
the code correctly, when rebase.instructionFormat is in use.


[Reference]

*1* https://lore.kernel.org/git/pull.757.v3.git.git.1586573067.gitgitgadget@gmail.com/

  reply	other threads:[~2020-05-07  4:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  4:27 rebase -i: quick/inline reword Solomon Ucko
2020-05-07  4:52 ` Junio C Hamano [this message]
2020-05-07 11:46   ` Jeff King
2020-05-07 12:17     ` Sergey Organov
2020-05-07 14:01   ` Solomon Ucko
2020-05-07 10:49 ` Sergey Organov
2020-05-08  0:05   ` brian m. carlson
2020-05-08 21:14     ` Sergey Organov
2020-08-16  0:14       ` Johannes Altmanninger
2020-08-16  5:36         ` Junio C Hamano
2020-08-16 12:24           ` Sergey Organov
2020-08-16 16:55             ` Junio C Hamano
2020-08-16 12:21         ` Sergey Organov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqzhak4a9o.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=solly.ucko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).